New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPLE2E.SYM; Corrections/questions/comments about a few definitions #484

Closed
TommyGH opened this Issue Aug 26, 2017 · 11 comments

Comments

Projects
None yet
3 participants
@TommyGH

TommyGH commented Aug 26, 2017

  1. 0032 INVFLG/PROMPT

Shouldn't this be:

0032 INVFLG
0033 PROMPT

  1. 0044 A5L/MACSTAT

Not a big deal, but if you know, what is MACSTAT? I've never seen it before.

  1. 002E MASK/TEMPOP

Once again, not a big deal, but what is TEMPOP?

The MONITOR ROM defines:
002E MASK
002E CHKSUM
002E FORMAT

0028 BASL
0029 BAS2L
002B BAS2H

Here there is a problem. BASH is not defined, and BAS2L is wrongly defined. These should be:

0028 BASL
0029 BASH
002A BAS2L
002B BAS2H

  1. I was looking at the definitions after $C600 and the comment ";Disk Drive". To me it looks like none of the definitions in this range ($C600..$C6FF) have anything to do with a disk drive controller.

Not a big deal, but any idea what they are?

In addition, I expected to see some of the following defined:

C600
C65C
C683
C6A6

That's it for now.

@Michaelangel007

This comment has been minimized.

Show comment
Hide comment
@Michaelangel007

Michaelangel007 Aug 26, 2017

Contributor

Thanks for the bug report Tommy.

I don't know who compiled that initial APPLE2E.SYM file but yes there are clearly some wrong entry points listed there:

  • INVFLG/PROMPT
                44   INVFLG   EQU   $32
                45   PROMPT   EQU   $33
Contributor

Michaelangel007 commented Aug 26, 2017

Thanks for the bug report Tommy.

I don't know who compiled that initial APPLE2E.SYM file but yes there are clearly some wrong entry points listed there:

  • INVFLG/PROMPT
                44   INVFLG   EQU   $32
                45   PROMPT   EQU   $33
@Michaelangel007

This comment has been minimized.

Show comment
Hide comment
@Michaelangel007

Michaelangel007 Aug 26, 2017

Contributor

TL:DR;

  • 0044 A5L/MACSTAT -- Not a bug

I'm also not familiar with MACSTAT but a little bit of google-fu reveals: Machine State

The Apple //c Reference Manual Vol. 2, Appendix I, Page 127

67 * Note: In Apple II, //e, both interrupts and BRK destroyed 
68 * location $45. Now only BRK destroys $45 (ACC) and it 
69 * also destroys $44 (MACSTAT). 
70 * 
71 MACSTAT EQU $44 ;Machine state after BRK 

@tomcw We probably should have separate symbols by model for if/when //c emulations gets added to AppleWin.

Contributor

Michaelangel007 commented Aug 26, 2017

TL:DR;

  • 0044 A5L/MACSTAT -- Not a bug

I'm also not familiar with MACSTAT but a little bit of google-fu reveals: Machine State

The Apple //c Reference Manual Vol. 2, Appendix I, Page 127

67 * Note: In Apple II, //e, both interrupts and BRK destroyed 
68 * location $45. Now only BRK destroys $45 (ACC) and it 
69 * also destroys $44 (MACSTAT). 
70 * 
71 MACSTAT EQU $44 ;Machine state after BRK 

@tomcw We probably should have separate symbols by model for if/when //c emulations gets added to AppleWin.

@Michaelangel007

This comment has been minimized.

Show comment
Hide comment
@Michaelangel007

Michaelangel007 Aug 26, 2017

Contributor

Consolidated list for (easier) reading ...

  • 0032 INVFLG/PROMPT
  • 0044 A5L/MACSTAT
  • 002E MASK/TEMPOP -- where does TEMPOP come from ?
  • BASH, BAS2L
  • Disk Drives
  • [ ] C600 -- no official symbol ?
  • [ ] C65C, //c lists this as the non-descript EXTENT -- who the frack named this one??? -- but this is definitely a common entry point. NOTE: ProDOS in BOOT.SRC copies $C663 .. $C6EB to RAM.
  • C683, RDSECT
  • C6A6 -- no official symbol ?

If anyone wants the actual $C600 Drive Symbols they can create a new issue (Feature Request Enhancement.)

Contributor

Michaelangel007 commented Aug 26, 2017

Consolidated list for (easier) reading ...

  • 0032 INVFLG/PROMPT
  • 0044 A5L/MACSTAT
  • 002E MASK/TEMPOP -- where does TEMPOP come from ?
  • BASH, BAS2L
  • Disk Drives
  • [ ] C600 -- no official symbol ?
  • [ ] C65C, //c lists this as the non-descript EXTENT -- who the frack named this one??? -- but this is definitely a common entry point. NOTE: ProDOS in BOOT.SRC copies $C663 .. $C6EB to RAM.
  • C683, RDSECT
  • C6A6 -- no official symbol ?

If anyone wants the actual $C600 Drive Symbols they can create a new issue (Feature Request Enhancement.)

@Michaelangel007

This comment has been minimized.

Show comment
Hide comment
@Michaelangel007

Michaelangel007 Aug 26, 2017

Contributor
  • MASK/TEMPOP

I've asked in c.s.a2.p: Origin of TEMPOP $2E ?

This might be our only clue ...
`

As far as I can tell it looks like someone was trying to describe FORMAT from Apple //c Reference Manual Vol 2
42 FORMAT EQU $2E ;temp for opcode decode
43 LENGTH EQU $2F ;temp for opcode decode

We should rename the symbol to be:

002E F8.MASK/F8.FORMAT

Used the shorter symbol name:

002E F8.MASK

Contributor

Michaelangel007 commented Aug 26, 2017

  • MASK/TEMPOP

I've asked in c.s.a2.p: Origin of TEMPOP $2E ?

This might be our only clue ...
`

As far as I can tell it looks like someone was trying to describe FORMAT from Apple //c Reference Manual Vol 2
42 FORMAT EQU $2E ;temp for opcode decode
43 LENGTH EQU $2F ;temp for opcode decode

We should rename the symbol to be:

002E F8.MASK/F8.FORMAT

Used the shorter symbol name:

002E F8.MASK

@Michaelangel007

This comment has been minimized.

Show comment
Hide comment
@Michaelangel007

Michaelangel007 Aug 28, 2017

Contributor

Disk Drive Symbols in question:

; Disk Drive
C603 TSTZPG
C607 ZP1
C610 ZP2
C623 ZP3
C628 ZPERROR
C62E TSTMEM
C638 MEM1
C63A MEM2
C655 MEM3
C657 MEM4
C65C MEM5
C667 MEM6
C670 MEM7
C688 MEM8
C68A MEM9
C68F MEMA
C69E MEMB
C6AD MEMC
C6BE SWCHTST1
C6CC MEMERROR
C6CD BADBITS
C6D7 BBITS1
C6DB CLRSTS
C6EB CLRS
Contributor

Michaelangel007 commented Aug 28, 2017

Disk Drive Symbols in question:

; Disk Drive
C603 TSTZPG
C607 ZP1
C610 ZP2
C623 ZP3
C628 ZPERROR
C62E TSTMEM
C638 MEM1
C63A MEM2
C655 MEM3
C657 MEM4
C65C MEM5
C667 MEM6
C670 MEM7
C688 MEM8
C68A MEM9
C68F MEMA
C69E MEMB
C6AD MEMC
C6BE SWCHTST1
C6CC MEMERROR
C6CD BADBITS
C6D7 BBITS1
C6DB CLRSTS
C6EB CLRS
@Michaelangel007

This comment has been minimized.

Show comment
Hide comment
@Michaelangel007

Michaelangel007 Aug 28, 2017

Contributor

Also see #425 for Drive IO soft switches revamp.

Contributor

Michaelangel007 commented Aug 28, 2017

Also see #425 for Drive IO soft switches revamp.

@Michaelangel007

This comment has been minimized.

Show comment
Hide comment
@Michaelangel007

Michaelangel007 Aug 28, 2017

Contributor

The disk drive symbols are correct. -- the comment is misleading though! They come from the Jan. 1987(*) IIe Technical Reference Manual (216 MB), Page 317 (PDF Page 345) when the Built-In Memory Test is run $C3XX ROM space.

c300_1

c300_2

(*) Note: There are TWO versions of the IIe TRM, 1985 and 1987.

Contributor

Michaelangel007 commented Aug 28, 2017

The disk drive symbols are correct. -- the comment is misleading though! They come from the Jan. 1987(*) IIe Technical Reference Manual (216 MB), Page 317 (PDF Page 345) when the Built-In Memory Test is run $C3XX ROM space.

c300_1

c300_2

(*) Note: There are TWO versions of the IIe TRM, 1985 and 1987.

@Michaelangel007 Michaelangel007 added this to the 1.27 milestone Aug 28, 2017

@Michaelangel007

This comment has been minimized.

Show comment
Hide comment
@Michaelangel007

Michaelangel007 Aug 28, 2017

Contributor

Tagging as 1.27 Keeping open as a reminder that docs/Debugger_Changelog.txt needs to be updated when #480 is merged.

Contributor

Michaelangel007 commented Aug 28, 2017

Tagging as 1.27 Keeping open as a reminder that docs/Debugger_Changelog.txt needs to be updated when #480 is merged.

@Michaelangel007

This comment has been minimized.

Show comment
Hide comment
@Michaelangel007

Michaelangel007 Aug 28, 2017

Contributor

Tommy,

Here is the latest APPLE2E.SYM that you can use until the next version of AppleWin is released.

Contributor

Michaelangel007 commented Aug 28, 2017

Tommy,

Here is the latest APPLE2E.SYM that you can use until the next version of AppleWin is released.

@tomcw

This comment has been minimized.

Show comment
Hide comment
@tomcw

tomcw Sep 9, 2017

Contributor

If anyone wants the actual $C600 Drive Symbols they can create a new issue (Feature Request Enhancement.)

These symbols would be a property of the card itself, so this feature is already covered by this issue+comment: #425 (comment)

Contributor

tomcw commented Sep 9, 2017

If anyone wants the actual $C600 Drive Symbols they can create a new issue (Feature Request Enhancement.)

These symbols would be a property of the card itself, so this feature is already covered by this issue+comment: #425 (comment)

@tomcw

This comment has been minimized.

Show comment
Hide comment
@tomcw

tomcw Jan 6, 2018

Contributor

Bumped debugger version (2.9.0.12) & updated docs/Debugger_Changelog.txt.

Contributor

tomcw commented Jan 6, 2018

Bumped debugger version (2.9.0.12) & updated docs/Debugger_Changelog.txt.

@tomcw tomcw closed this Jan 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment