New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save then restore state with IN#2 in Lisa Assembler v2.5D #486

Closed
dvot197007 opened this Issue Sep 19, 2017 · 9 comments

Comments

Projects
None yet
2 participants
@dvot197007

dvot197007 commented Sep 19, 2017

Hello,

After enabling TCP, I loaded the Lisa assembler v2.5D disk (from Asimov) into drive 1. Then ctrl-D (to allow DOS commands) followed by IN#2. Then doing a save and restore state drops me into the monitor. This problem also occurs in AppleWin 1.25.

The reason for wanting to do this is to automatically get the Lisa assembler into a state where I can pipe commands over TCP.

Thanks,
DOT

@tomcw

This comment has been minimized.

Show comment
Hide comment
@tomcw

tomcw Sep 20, 2017

Contributor

Repro:

  • Boot to AppleSoft
  • IN#2
  • Save state, then load state

Crashes to monitor

Contributor

tomcw commented Sep 20, 2017

Repro:

  • Boot to AppleSoft
  • IN#2
  • Save state, then load state

Crashes to monitor

@tomcw

This comment has been minimized.

Show comment
Hide comment
@tomcw

tomcw Sep 20, 2017

Contributor

I guess that the state of the SSC's expansion ROM isn't being correctly (saved?) restored to $C800-CFFF.

Contributor

tomcw commented Sep 20, 2017

I guess that the state of the SSC's expansion ROM isn't being correctly (saved?) restored to $C800-CFFF.

@tomcw tomcw self-assigned this Sep 20, 2017

@tomcw

This comment has been minimized.

Show comment
Hide comment
@tomcw

tomcw Sep 22, 2017

Contributor

As suspected, the expansion ROM wasn't being correctly restored and the PC was running in this space,
Fixed in 3a5bf01.
To do: Add a regression test.

Contributor

tomcw commented Sep 22, 2017

As suspected, the expansion ROM wasn't being correctly restored and the PC was running in this space,
Fixed in 3a5bf01.
To do: Add a regression test.

@dvot197007

This comment has been minimized.

Show comment
Hide comment
@dvot197007

dvot197007 Sep 23, 2017

That seems to have fixed the problem - I built from the new source using Visual Studio 2015 and my problem with the Lisa assembler and IN#2 has gone.
Do I need to close the issue or will someone else do that?
Also, will the bug fix be rolled into the current version of AppleWin or will it have to wait for the next release?
Anyway, thanks very much,
David

dvot197007 commented Sep 23, 2017

That seems to have fixed the problem - I built from the new source using Visual Studio 2015 and my problem with the Lisa assembler and IN#2 has gone.
Do I need to close the issue or will someone else do that?
Also, will the bug fix be rolled into the current version of AppleWin or will it have to wait for the next release?
Anyway, thanks very much,
David

@tomcw

This comment has been minimized.

Show comment
Hide comment
@tomcw

tomcw Sep 23, 2017

Contributor

Thanks for confirming the fix.

Do I need to close the issue or will someone else do that?

No. I need to add a regression test. Then I will close this bug.

Also, will the bug fix be rolled into the current version of AppleWin or will it have to wait for the next release?

What version of AppleWin are you using?

Recently I've been doing "experimental" releases for small, targeted updates - mainly for specific users. The latest is 1.26.3.0, here.
Since this release (2 months ago) there have been some minor fixes, mainly to the built-in debugger.

And the latest "official" release was mid-Feb, 7 months ago... so maybe time to put out a new official version.

Contributor

tomcw commented Sep 23, 2017

Thanks for confirming the fix.

Do I need to close the issue or will someone else do that?

No. I need to add a regression test. Then I will close this bug.

Also, will the bug fix be rolled into the current version of AppleWin or will it have to wait for the next release?

What version of AppleWin are you using?

Recently I've been doing "experimental" releases for small, targeted updates - mainly for specific users. The latest is 1.26.3.0, here.
Since this release (2 months ago) there have been some minor fixes, mainly to the built-in debugger.

And the latest "official" release was mid-Feb, 7 months ago... so maybe time to put out a new official version.

@tomcw

This comment has been minimized.

Show comment
Hide comment
@tomcw
Contributor

tomcw commented Sep 23, 2017

@tomcw tomcw closed this Sep 23, 2017

@tomcw tomcw added this to the 1.27 milestone Sep 23, 2017

@tomcw

This comment has been minimized.

Show comment
Hide comment
@tomcw

tomcw Sep 29, 2017

Contributor

NB. This bug still exists in v1 save-states, but I have no plans to update support for this old format.

Contributor

tomcw commented Sep 29, 2017

NB. This bug still exists in v1 save-states, but I have no plans to update support for this old format.

@tomcw

This comment has been minimized.

Show comment
Hide comment
@tomcw

tomcw Sep 30, 2017

Contributor

FYI, new experimental release build 1.26.3.1 here, which includes this fix.

Contributor

tomcw commented Sep 30, 2017

FYI, new experimental release build 1.26.3.1 here, which includes this fix.

@dvot197007

This comment has been minimized.

Show comment
Hide comment
@dvot197007

dvot197007 Oct 3, 2017

dvot197007 commented Oct 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment