Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load state discards pending interrupt #677

Closed
peterferrie opened this issue Aug 22, 2019 · 9 comments

Comments

@peterferrie
Copy link

commented Aug 22, 2019

If an interrupt was pending at the time when the state was saved (e.g. save state when PLP is about to execute), the interrupt does not fire when the state is reloaded (i.e. after PLP runs).

@tomcw

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2019

Thanks Peter. I'll look into fixing this shortly.

@tomcw tomcw added the bug label Aug 23, 2019
@tomcw

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

Commit 94bbc5e fixes this.

Regression test added here: AppleWin/AppleWin-Test@7ea40c3

@tomcw tomcw added this to the 1.29.2 milestone Aug 26, 2019
@peterferrie

This comment has been minimized.

Copy link
Author

commented Aug 26, 2019

tomcw added a commit that referenced this issue Aug 26, 2019
…ouse & SSC. (#677)

NB. Small opt to CheckInterruptSources() to explicitly test sg_Mouse.IsActive() first.
@tomcw

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

Peter - I assume you don't need a fix for this in any great hurry. So it'll just get included in the next release (which may happen in ~a few weeks' time).

@peterferrie

This comment has been minimized.

Copy link
Author

commented Aug 26, 2019

@sicklittlemonkey

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

@tomcw

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

Yep - I really appreciated bugs for these edge-cases being raised.

It was fiddly to repro, so in the end I just wrote this code:
https://github.com/AppleWin/AppleWin-Test/blob/master/Projects/GH677-IRQ-Pending/irq-pending.a
... then created a save-state at the point that CLI was about to be executed.

@tomcw

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

FYI, new AppleWin build 1.29.2 here.

@tomcw

This comment has been minimized.

Copy link
Contributor

commented Oct 12, 2019

Closing as fixed.

@tomcw tomcw closed this Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.