Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S7 Empty on Exit issue #790

Closed
Harbinger-365 opened this issue May 24, 2020 · 8 comments
Closed

S7 Empty on Exit issue #790

Harbinger-365 opened this issue May 24, 2020 · 8 comments
Labels
Milestone

Comments

@Harbinger-365
Copy link

@Harbinger-365 Harbinger-365 commented May 24, 2020

Hi guys,

Thanks again for adding in both the -s7-empty-on-exit and the -conf command line options. I have noticed however that when using the -conf flag -s7-empty-on-exit no longer works. In what might be a related issue I dont think Starting Directory, or HDV Starting Directory are updating in the ini file when you load an image via -d1, -d2, -h1, etc which means that pressing f11 to save or f12 to load will look in the folder of the last image you manually loaded instead of the folder of the image mounted via -d1. I think it also effects which folder is shown if you press f3\f4 to load another disk.

Hope thats all clear, if not please let me know and ill try to explain it different.

@tomcw
Copy link
Contributor

@tomcw tomcw commented May 25, 2020

Thanks for raising this. I will take a look and report back.

@tomcw
Copy link
Contributor

@tomcw tomcw commented May 25, 2020

I have noticed however that when using the -conf flag -s7-empty-on-exit no longer works.

This regressed at 1.29.7.0 (Dec'19) - when I added '-s5 diskii'.
NB. -s7-empty-on-exit was added at 1.29.3.0 (Oct'19).

@tomcw tomcw added the bug label May 25, 2020
@tomcw
Copy link
Contributor

@tomcw tomcw commented May 25, 2020

In what might be a related issue I dont think Starting Directory, or HDV Starting Directory are updating in the ini file when you load an image via -d1, -d2, -h1, etc

I can reproduce this issue using -d1, -d2 (but not -h1, -h2).

tomcw added a commit that referenced this issue May 25, 2020
. -s7-empty-on-exit wasn't being recognised
. -d1, -d2 weren't saving the 'Last Disk Image 1/2' & 'Starting Directory'
@Harbinger-365
Copy link
Author

@Harbinger-365 Harbinger-365 commented May 26, 2020

Thanks for looking into it Tom

@tomcw
Copy link
Contributor

@tomcw tomcw commented May 26, 2020

Added tests for these regressions: AppleWin/AppleWin-Test@b778286

@tomcw tomcw added this to the 1.29.13 milestone May 26, 2020
@tomcw
Copy link
Contributor

@tomcw tomcw commented May 31, 2020

@Harbinger-365 - please try this new AppleWin 1.29.13.0, here, and let me know if it resolves the issues you reported here.

@Harbinger-365
Copy link
Author

@Harbinger-365 Harbinger-365 commented Jun 1, 2020

Hi @tomcw , Looks like that version has fixed the issues. Thanks!

While looking into this I think I found whats causing #691 as well. I think its something to do with when the "starting directory" line is being updated when using the -d1\-d2 command line switch. When you load applewin and press f11 or f12 it will open whatever folder was in the "starting directory" line before applewin loaded, not the folder of the game currently loaded. This makes me think that whatever is behind f11\f12 is looking at the "starting directory" line before it has been updated to the current path. I currently get around this by loading a game, quiting, and loading it again in my bat file. Its even worse when using the -h1\-h2 command line switch as it never updates the "starting directory" line at all due to using "HDV Starting Directory" so even on a subsequent load f11\f12 will not load the folder of the current game. For some reason F3\F4 is not affected by this issue and will always open the current folder.

Again if that doesnt make sense let me know and ill try to explain what I mean another way. If you would rather this be made a separate issue do you need me to copy it into one?

@tomcw
Copy link
Contributor

@tomcw tomcw commented Jun 1, 2020

Thanks for confirming that the original issue is now fixed.

Also thanks for additional info about the "starting directory" relating to f11/f12.
I will transfer this info to #691, and close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants