Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

video modes are becoming a mess #852

Open
mdhoney opened this issue Oct 27, 2020 · 19 comments
Open

video modes are becoming a mess #852

mdhoney opened this issue Oct 27, 2020 · 19 comments
Labels

Comments

@mdhoney
Copy link

mdhoney commented Oct 27, 2020

As of the latest version, you can choose the following video modes (Video.cpp):

	TEXT("Monochrome (Custom)\0")
	TEXT("Color (Composite Idealized)\0")		// newly added
	TEXT("Color (RGB Card/Monitor)\0")	// was "Color (RGB Monitor)"
	TEXT("Color (Composite Monitor)\0")	// was "Color (NTSC Monitor)"
	TEXT("Color TV\0")
	TEXT("B&W TV\0")
	TEXT("Monochrome (Amber)\0")
	TEXT("Monochrome (Green)\0")
	TEXT("Monochrome (White)\0")

I think the menu is becoming overloaded, and somewhat confusing. RGB and Composite Idealized look almost identical in v.1.29.15.0. Also, can we move the "Monochrome (Custom)" to the bottom of this list?

@tomcw tomcw added the UI label Oct 27, 2020
@tomcw
Copy link
Contributor

tomcw commented Oct 27, 2020

video modes are becoming a mess
I think the menu is becoming overloaded, and somewhat confusing.

Other than move "Monochrome (Custom)" to the bottom of this list (which I agree with) what else do you suggest doing? Moving 1 item from the top to the bottom doesn't really solve anything.

@sicklittlemonkey
Copy link
Contributor

sicklittlemonkey commented Oct 27, 2020 via email

@Lisias
Copy link

Lisias commented Oct 28, 2020

RGB and Composite Idealized look almost identical in v.1.29.15.0.

Nope. RGB has some additional (color) text modes (somewhat similar to the IIgs). They are not the same.

@mdhoney
Copy link
Author

mdhoney commented Oct 28, 2020

Nope. RGB has some additional (color) text modes (somewhat similar to the IIgs). They are not the same.

Can you give a good example? I was using the intro to the Bard's Tale which might not be the best test...

@tomcw
Copy link
Contributor

tomcw commented Oct 28, 2020

Bard's Tale's intro is HGR... and RGB HGR is virtually the same as the Idealized HGR (just no half-dot shift in RGB video mode).

Try looking at a DHGR game: for RGB DHGR this is rendered as 140x192 "chunky" pixels, unless one of the new RGB modes has been software-selected (eg. B&W or Mixed Colour/B&W).

Beyond this as @Lisias says there are additional colour text modes, see this issue for example screenshots: #826.

But it seems like we aren't doing a good job of advertising what AppleWin is now capable of. What I mean is that the AppleWin.chm (help file) has no screenshots, so from a causal read you can't readily see what kind of images you'll get with the different video modes. Would some screenshots added to AppleWin.chm help?

@Michaelangel007
Copy link
Contributor

@tomcw Feel free to add these images to the help.

  1. Composite Idealized
  • 1_Composite_Idealized
  1. RGB Card
  • 2_RGB_Card_Moniotor

3, NTSC Monitor

  • 3_NTSC_Monitor
  1. Color TV
  • 4_Color_TV

5, Black and White TV

  • 5_Black_and_White_TV

6, Monochrome Amber

  • 6_Monochrome_Amber
  1. Monochrome Green
  • 7_Monochrome_Green
  1. Monochrome White
  • 8_Monochrome_White
  1. Monochrome Custom
  • 9_Monochrome_Custom

Do we need/want to show a regular HGR image as well?
i.e.

  • Aztec
  • Archon

@Michaelangel007
Copy link
Contributor

@sicklittlemonkey Agreed that this should be customizable and regrettably another dialog tab.

UI mock-up:

Video Monitor/Modes:

|Composite Idealized|  [-->]  |NTSC Monitor    |
|RGB Card           |         |Monochrome Green|
|Color TV           |  [<--]  |                |
|Black and White TV |         |                |
|Monochrome Amber   |         |                |
|Monochrome White   |         |                |
|Monochrome Custom  |         |                |

@tomcw
Copy link
Contributor

tomcw commented Oct 30, 2020

Thanks Michael for those images - I'll start with those.
I may add (eg) Aztec for HGR, since it shows use of vertical blend and half-dot shift.

@Michaelangel007
Copy link
Contributor

@tomcw Aztec HGR

  1. Composite Idealized
  • 1_Composite_Idealized
  1. RGB Card
  • 2_RGB_Card
  1. NTSC Monitor
  • 3_NTSC_Monitor
  1. Color TV
  • 4_Color_TV
  1. Black and White TV
  • 5_Black_and_White_TV
  1. Monochrome Amber
  • 6_Monochrome_Amber
  1. Monochrome Green
  • 7_Monochrome_Green
  1. Monochrome White
  • 8_Monochrome_White
  1. Monochrome Custom
  • 9_Monochrome_Custom

@sicklittlemonkey
Copy link
Contributor

sicklittlemonkey commented Oct 30, 2020 via email

@tomcw
Copy link
Contributor

tomcw commented Oct 31, 2020

Thanks @Michaelangel007 (I'll redo the Aztec / "Composite Idealized" so that 'Vertical Blend' is enabled).

@sicklittlemonkey - yeah maybe Airheart's title (or Prince of Persia's title) is a more well recognised DHGR image. But I think I'll only use one set of images, so as not to overwhelm anyone reading the help.

@mdhoney
Copy link
Author

mdhoney commented Nov 1, 2020

Thanks @Michaelangel007 and @tomcw - here are the same modes with Airheart's (DHGR) title screen. Feel free to use.

  • Composite Idealized:
    AppleWin - Airheart (Composite Idealized)

  • RGB Card:
    AppleWin - Airheart (RGB)

  • Composite Monitor:
    AppleWin - Airheart (Composite Monitor)

  • Color TV:
    AppleWin - Airheart (Color TV)

  • B&W TV:
    AppleWin - Airheart (B W TV)

  • Monochrome (Amber):
    AppleWin - Airheart (Monochrome, Amber)

  • Monochrome (Green):
    AppleWin - Airheart (Monochrome, Green)

  • Monochrome (White):
    AppleWin - Airheart (Monochrome, White)

  • Monochrome (Custom):
    AppleWin - Airheart (Monochrome, Custom)

@mdhoney
Copy link
Author

mdhoney commented Nov 1, 2020

One more thing regarding the Bard's Tale intro. Yes I know this is only HGR, but why do both "Composite Idealized" and "RGB Card" blend the lettering together (look at the letter m in "men") whereas "Composite Monitor" does not?

  • Composite Idealized:
    AppleWin - Bard's Tale (Composite Idealized)

  • RGB Card:
    AppleWin - Bard's Tale (RGB Card)

  • Composite Monitor:
    AppleWin - Bard's Tale (Composite Monitor)

@mdhoney
Copy link
Author

mdhoney commented Nov 1, 2020

Other than move "Monochrome (Custom)" to the bottom of this list (which I agree with) what else do you suggest doing? Moving 1 item from the top to the bottom doesn't really solve anything.

You have a point @tomcw. Do we actually need the "Monochrome (Custom)" setting? It's neat but not related to any real hardware (as far as I know). Similarly, since "Composite Idealized" was never achieved in real hardware, how about we add a checkbox "Idealized Composite Monitor" (which controls the "Composite Monitor" setting) and then remove that from the drop-down menu?
Sorry if I didn't explain this well, happy to provide a mock-up...

@tomcw
Copy link
Contributor

tomcw commented Nov 1, 2020

One more thing regarding the Bard's Tale intro. Yes I know this is only HGR, but why do both "Composite Idealized" and "RGB Card" blend the lettering together (look at the letter m in "men") whereas "Composite Monitor" does not?

In HGR, "Composite Idealized" and "RGB Card" are virtually the same (accept there's no half-dot shift for "RGB Card"). See the AZTEC images above for the letters 'A' and 'Y' in the "PRESS ANY KEY" text.

btw, in "Composite Idealized" you can also enable 'Vertical Blend' to produce new blended colours for both hats.

On to your question...

"RGB Card" will have a 2-dot (hires pixel) rolling window used to generate the colour (black, white + 2 colours), and also use the byte's high-bit to select the palette for the 2 colours (purple/green or orange/blue). The letter 'm' is formed of the bit pattern 1101011. Black is defined at '00' (2 adjacent zeros), which doesn't appear in 'm' / 1101011.

"Composite Monitor" emulated a higher bandwidth than TVs, because of this, it's able to render these black pixels (eg. hires 1101011 -> dhires pixels 11110011001111, so now we have '00' patterns present, so will get black dots). This is a fairly gross simplification, but hopefully it's good enough!

@sicklittlemonkey
Copy link
Contributor

@mdhoney Thanks for the Airheart and other images.

@tomcw If the idea is too put these in the help file, I think side-by-side comparisons would be good.

But the differentiating features of each mode are definitely shown better in different images.

Composite idealized (which I don't care for, but ...) mode's vertical blend is better shown in Aztec.

But I think RGB vs composite TV horizontal detail and colour blending are better shown in Airheart.

Then again, Airheart looks surprisingly similar in composite idealized and composite TV, which really goes to show that the composite idealized served its purpose well before the NTSC emulation! : - )

@mdhoney
Copy link
Author

mdhoney commented Nov 2, 2020

btw, in "Composite Idealized" you can also enable 'Vertical Blend' to produce new blended colours for both hats.

Yes, thanks for the reminder. Here's the Bard's Tale intro again...

  • Composite Idealized, Vertical Blend off:
    AppleWin - Bard's Tale (Composite Idealized) cr

  • Composite Idealized, Vertical Blend on:
    AppleWin - Bard's Tale (Composite Idealized, Vertical Blend) cr

@tomcw
Copy link
Contributor

tomcw commented Nov 2, 2020

Do we actually need the "Monochrome (Custom)" setting? It's neat but not related to any real hardware (as far as I know).

@mdhoney: I don't know, as we have no telemetry in AppleWin. Personally I never use it, so dropping it wouldn't bother me, but I bet there are some that are using it (as the feature has been around for ~20 years... it predates me!).

Composite idealized (which I don't care for, but ...)

@sicklittlemonkey: ...a confusing name, for a "fake" mode adding confusing value :-/ Historically this (as you say) is the mode that existed before the NTSC support was added. As you know we did drop this video mode for 3 years, but I reinstated it due to much 'voice of customer' demand to restore it (see #357).

I use it, and see it as a best of many worlds, ie. crisp TEXT (40/80 col) like RGB (so not like Color TV), but with non-chunky dhires pixels so more like Color TV (ie. not like RGB), and continuous horizontal colour (unlike the Color Composite Monitor). If the Airheart image had 80-column TEXT in the bottom of the screen, then you'd see the difference.

If the idea is too put these in the help file, I think side-by-side comparisons would be good.

Yes, I totally agree.

@Michaelangel007
Copy link
Contributor

I occasionally use Monochrome custom mode. It was provided because not everyone liked the 3 hard-coded monochrome colors.

There is no need to remove it when it works.

It would be better to allow users to customize what video modes they want with the dialog box -- and default the Monochrome Custom setting to OFF. That way a user can F9 through the video modes they actually use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants