Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upMemory fix #715
Merged
Memory fix #715
Conversation
This comment has been minimized.
This comment has been minimized.
I think there is a more elegant way to handle this but it requires a newer c++.
|
Signed-off-by: Andrea Odetti <mariofutire@gmail.com>
This comment has been minimized.
This comment has been minimized.
I've removed VirtualAlloc and simplified the code. Nothing else to push on this branch. IMHO, it is ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
audetto commentedNov 2, 2019
ImageInfo must be initialised by calling its c++ constructor (as it contains std::string).
In VS it seems to work (by chance?), in g++ it fails.
C++ standard requires the constructor anyway.