Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security permissions break connections #1074

Closed
thatsIch opened this issue Mar 22, 2015 · 7 comments
Closed

Security permissions break connections #1074

thatsIch opened this issue Mar 22, 2015 · 7 comments
Labels
bug Self explanatory?

Comments

@thatsIch
Copy link
Member

Issue to summarize the issue regarding security permissions:

  • while chunks load into existing networks, there can be race conditions, where the "new" network will not be accepted into the main network
  • this results into breaking the border connection
  • depending on servers and mods, there can be rapid loading and unloadings of chunks

Temporary fix:

  • chunk-load the entire network
  • insert a blank permission (master permission for everybody)

Feel free to edit this, if anything was incorrect or incomplete

@thatsIch thatsIch added the bug Self explanatory? label Mar 22, 2015
@Flukethoughts
Copy link

blank did not help

@yueh
Copy link
Member

yueh commented Mar 25, 2015

Any idea why the CableBusContainer is using a ThreadLocal<Boolean>?

@thatsIch
Copy link
Member Author

no, a private static boolean should suffice imo.

@Farbdose
Copy link

Farbdose commented Sep 28, 2017

Just being curious:
as the break happens because ae2 security drop doesn't know who placed the cable that just appeared out of nowhere (new junk was loaded) could this be circumvented by placing an additional security terminal in every chunk that isn't permanently chunk-loaded so ae2 can see
"Hey this cable belongs to another network with a security terminal that was placed by the same user as this network, let's connect!"

@yueh
Copy link
Member

yueh commented Jan 29, 2018

Closing, as this can easily be caused by the TE/chunk corruption bugs in forge, which exist since 1.7.10 or maybe earlier.

@Solverbolt
Copy link

Good to know that this issue is being ignored despite it still being very much active as of now

@Solverbolt
Copy link

cannot even play because its kicking out error popups over the top of the screen.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Self explanatory?
Projects
None yet
Development

No branches or pull requests

5 participants