New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TickHandler / Callable memory leak #1283

Closed
sfPlayer1 opened this Issue Apr 14, 2015 · 0 comments

Comments

Projects
None yet
2 participants
@sfPlayer1

The system mentioned above can leak memory when worlds unload if the callable references a world object, even though it's using a WeakHashMap. MeteoriteWorldGen.MeteoriteSpawn is where I've noticed it.

I'd replace Callable with a custom interface that passes the World object with the invocation, removing the need to store it at the target, e.g. void call(World).

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Aug 6, 2015

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Aug 6, 2015

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Aug 20, 2015

@yueh yueh closed this in #1776 Aug 22, 2015

yueh added a commit that referenced this issue Aug 22, 2015

Merge pull request #1776 from yueh/feature-1283
Closes #1283: Add custom Callable to prevent memory leaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment