TickHandler / Callable memory leak #1283

Closed
sfPlayer1 opened this Issue Apr 14, 2015 · 0 comments

Projects

None yet

2 participants

@sfPlayer1

The system mentioned above can leak memory when worlds unload if the callable references a world object, even though it's using a WeakHashMap. MeteoriteWorldGen.MeteoriteSpawn is where I've noticed it.

I'd replace Callable with a custom interface that passes the World object with the invocation, removing the need to store it at the target, e.g. void call(World).

@yueh yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Aug 6, 2015
@yueh yueh Closes #1283: Add custom Callable to prevent memory leaks a63581c
@yueh yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Aug 6, 2015
@yueh yueh Closes #1283: Add custom Callable to prevent memory leaks 96b240b
@yueh yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Aug 20, 2015
@yueh yueh Closes #1283: Add custom Callable to prevent memory leaks 0de7a2d
@yueh yueh closed this in #1776 Aug 22, 2015
@yueh yueh added a commit to thatsIch/Applied-Energistics-2 that referenced this issue Sep 30, 2015
@yueh @thatsIch yueh + thatsIch Closes #1283: Add custom Callable to prevent memory leaks 621952e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment