Slabs #1379

Closed
Yulife opened this Issue May 2, 2015 · 11 comments

Projects

None yet

4 participants

@Yulife
Yulife commented May 2, 2015

Slab variants for the decorative blocks in AE2 would be brilliant, especially the Sky Stone variant. Right now we've just got stairs so slabs would be very neat ~ 😄
Thanks in advance

@yueh yueh changed the title from [Feature] Slabs to Slabs May 2, 2015
@plumpudding
Contributor

You can assign me, I'd try to do that

@thatsIch
Member
thatsIch commented May 4, 2015

You can not assign people outside of the organisation

@plumpudding
Contributor

:O didn't know that.
So do we have some kind of ReflectionHelper util?

@thatsIch
Member
thatsIch commented May 4, 2015

like the Forge ReflectionHelper?

@plumpudding
Contributor

Forge has one? I'll try that one then.

@plumpudding
Contributor

A little progress for now: ac07657

@thatsIch
Member
thatsIch commented May 8, 2015

nice, the worst part comes, when you need to handle the merging of the slabs upon double place.

@yueh
Member
yueh commented May 8, 2015

The properties of slabs should probably be handle inside the slabs and not set through the IFeatureHandler.

@plumpudding
Contributor

Houston, we have a problem

getting double slabs up and running is not very difficult either, _but_ we need an ItemBlock which requires the Block to be constructed before the Items are. How would you do that? I'm not very familiar with the AE Api code..

@yueh @thatsIch

Aaaand just to be clear: It would already be possible to create Slabs and Stairs using FMP. I would not like to see my work being thrown away because Algo sees this as a duplicate feature..

@thatsIch
Member
thatsIch commented May 9, 2015

There should be an AEBaseItemBlock which accepts a Block.
You should probably extend that class and use that as a return type of the DoubleBlock

FMP is not AE

@plumpudding plumpudding referenced this issue May 10, 2015
Closed

add slabs #1439

@thatsIch thatsIch closed this in 5105a2b May 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment