Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slabs #1379

Closed
Yulife opened this issue May 2, 2015 · 11 comments
Closed

Slabs #1379

Yulife opened this issue May 2, 2015 · 11 comments
Labels

Comments

@Yulife
Copy link

@Yulife Yulife commented May 2, 2015

Slab variants for the decorative blocks in AE2 would be brilliant, especially the Sky Stone variant. Right now we've just got stairs so slabs would be very neat ~ 馃槃
Thanks in advance

@thatsIch thatsIch added the feature label May 2, 2015
@yueh yueh changed the title [Feature] Slabs Slabs May 2, 2015
@petabyteboy
Copy link
Contributor

@petabyteboy petabyteboy commented May 4, 2015

You can assign me, I'd try to do that

@thatsIch
Copy link
Member

@thatsIch thatsIch commented May 4, 2015

You can not assign people outside of the organisation

@petabyteboy
Copy link
Contributor

@petabyteboy petabyteboy commented May 4, 2015

:O didn't know that.
So do we have some kind of ReflectionHelper util?

@thatsIch
Copy link
Member

@thatsIch thatsIch commented May 4, 2015

like the Forge ReflectionHelper?

@petabyteboy
Copy link
Contributor

@petabyteboy petabyteboy commented May 4, 2015

Forge has one? I'll try that one then.

@petabyteboy
Copy link
Contributor

@petabyteboy petabyteboy commented May 8, 2015

A little progress for now: ac07657

@thatsIch
Copy link
Member

@thatsIch thatsIch commented May 8, 2015

nice, the worst part comes, when you need to handle the merging of the slabs upon double place.

@yueh
Copy link
Member

@yueh yueh commented May 8, 2015

The properties of slabs should probably be handle inside the slabs and not set through the IFeatureHandler.

@petabyteboy
Copy link
Contributor

@petabyteboy petabyteboy commented May 9, 2015

Houston, we have a problem

getting double slabs up and running is not very difficult either, _but_ we need an ItemBlock which requires the Block to be constructed before the Items are. How would you do that? I'm not very familiar with the AE Api code..

@yueh @thatsIch

Aaaand just to be clear: It would already be possible to create Slabs and Stairs using FMP. I would not like to see my work being thrown away because Algo sees this as a duplicate feature..

@thatsIch
Copy link
Member

@thatsIch thatsIch commented May 9, 2015

There should be an AEBaseItemBlock which accepts a Block.
You should probably extend that class and use that as a return type of the DoubleBlock

FMP is not AE

@petabyteboy petabyteboy mentioned this issue May 10, 2015
@thatsIch thatsIch closed this in 5105a2b May 25, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can鈥檛 perform that action at this time.