Skip to content

/ Applied-Energistics-2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charged Certus Quartz Ore has same name as Certus Quartz Ore #1588

Closed
JentheGeek opened this issue Jun 13, 2015 · 1 comment
Closed

Charged Certus Quartz Ore has same name as Certus Quartz Ore #1588

JentheGeek opened this issue Jun 13, 2015 · 1 comment
Assignees
@thatsIch
Labels
bug fixed

Comments

@JentheGeek
Copy link

@JentheGeek JentheGeek commented Jun 13, 2015

Minecraft: 1.7.1
JABBA,1.2.1
AppliedEnergetics2 (rv2-beta-18)
Infinity 1.7 Mod Pack

OreDictionary Dump via NEI shows:
oreCertusQuartz,1xtile.appliedenergistics2.OreQuartz@0,appliedenergistics2:tile.OreQuartz,Certus Quartz Ore,false
oreCertusQuartz,1xtile.appliedenergistics2.OreQuartzCharged@0,appliedenergistics2:tile.OreQuartzCharged,Charged Certus Quartz Ore,false

Because of the same item name (oreCertusQuartz), sorting with other mods such as JABBA does not occur correctly.
@thatsIch
Copy link
Member

@thatsIch thatsIch commented Jun 13, 2015

Cause both are the same block, just a different metadata/state,

your reasoning would imply, that oak wood and spruce wood is stored the same in Jabba (basically it replaces either of them with the other)
@thatsIch thatsIch added question bug and removed question labels Jun 13, 2015
@thatsIch thatsIch self-assigned this Jun 13, 2015
@thatsIch thatsIch added the fixed label Jun 13, 2015
@thatsIch thatsIch closed this in b5d0db4 Jun 13, 2015
thatsIch added a commit that referenced this issue Jun 13, 2015
@thatsIch
Merge pull request #1590 from thatsIch/b-1588-same-oredict-name-for-c…
Loading status checks…
349ac7e 
…ertus-ore-and-charged

Fixes #1588: Charged Certus Quartz Ore has its own oredictionary entry
thatsIch pushed a commit that referenced this issue Jun 14, 2015
thatsIch
Fixes #1588: Charged Certus Quartz Ore has its own oredictionary entry
09ed06e
@Oxosorrel Oxosorrel mentioned this issue Jun 14, 2015
Closed
thatsIch added a commit that referenced this issue Jun 18, 2015
thatsIch @thatsIch
Fixes #1588: Charged Certus Quartz Ore has its own oredictionary entry
efafaed 
Conflicts:
	src/main/java/appeng/block/solids/OreQuartz.java
thatsIch added a commit that referenced this issue Sep 3, 2015
@thatsIch
Merge pull request #1634 from thatsIch/b-1588-wrong-oredict-name
Loading status checks…
3bb9e4d 
Fixes #1588: Charged Certus Quartz Ore was given a wrong name
@thatsIch thatsIch mentioned this issue Sep 25, 2015
Closed
@wlhlm wlhlm mentioned this issue Jan 12, 2016
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@thatsIch thatsIch

Labels
bug fixed
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@thatsIch @JentheGeek