AE2 Seeds Problem with GregTech #1718

Closed
lordjoda opened this Issue Jul 17, 2015 · 9 comments

Comments

Projects
None yet
2 participants
@lordjoda

I already posted the issue at Blood-Asp/GT5-Unofficial#91 but since it seems GregTech is not directly involved in it, I want to mention it here again:
When crafting Fluix or Netherquarz seeds they are displayed and recognized as a different item then the crafting logic expects and therefore the autocrafting logic breaks. Tested with only ae2-rv2-stable9 and gt-5.08.24 and IC2-2.2.746 and default configs.
As seen in the other issue thread, the crafting recipe doesn't have a nbt tag "progress" but for whatever reason the crafted item has (immediately). Certus Quarz Seeds apparently don't have this issue.
If I can provide further Information please let me know!
ae2bug

@yueh

This comment has been minimized.

Show comment
Hide comment
@yueh

yueh Jul 17, 2015

Member

If I recall correctly, does GT not replace these and the certus ore with its own version?

Member

yueh commented Jul 17, 2015

If I recall correctly, does GT not replace these and the certus ore with its own version?

@lordjoda

This comment has been minimized.

Show comment
Hide comment
@lordjoda

lordjoda Jul 17, 2015

No the seeds are not replaced. The only "problem" really is the nbt tag

No the seeds are not replaced. The only "problem" really is the nbt tag

@yueh

This comment has been minimized.

Show comment
Hide comment
@yueh

yueh Jul 17, 2015

Member

Both spawned through creative and crafted ones have a NBT tag, when I try to reproduce it.

Member

yueh commented Jul 17, 2015

Both spawned through creative and crafted ones have a NBT tag, when I try to reproduce it.

@lordjoda

This comment has been minimized.

Show comment
Hide comment
@lordjoda

lordjoda Jul 17, 2015

Well yes indeed, but in the crafting recipe (so basically what the crafting logic searches for) it is not.

Well yes indeed, but in the crafting recipe (so basically what the crafting logic searches for) it is not.

@yueh

This comment has been minimized.

Show comment
Hide comment
@yueh

yueh Jul 17, 2015

Member

The crafting handler is resolving it including the NBT tag. So if this is missing, something is messing with the crafting handler.

Member

yueh commented Jul 17, 2015

The crafting handler is resolving it including the NBT tag. So if this is missing, something is messing with the crafting handler.

@lordjoda

This comment has been minimized.

Show comment
Hide comment
@lordjoda

lordjoda Jul 17, 2015

Hmm but from my tests its the opposite way:
Without GT:

  • Crafted item has no NBT Tag
  • Crafting recipe has no NBT Tag

With GT
-Crafted item has NBT Tag
-Crafting recipe has no NBT Tag

(The item on slot 1 is freshly crafted without gt and "stacks" with the recipe, the other 5 items where crafted with gt installed and do not stack with the recipe even without gt beeing present)
nbt

Hmm but from my tests its the opposite way:
Without GT:

  • Crafted item has no NBT Tag
  • Crafting recipe has no NBT Tag

With GT
-Crafted item has NBT Tag
-Crafting recipe has no NBT Tag

(The item on slot 1 is freshly crafted without gt and "stacks" with the recipe, the other 5 items where crafted with gt installed and do not stack with the recipe even without gt beeing present)
nbt

@yueh

This comment has been minimized.

Show comment
Hide comment
@yueh

yueh Jul 17, 2015

Member

Looks like the different seeds are handled differently, but each type is still behaves consistent.

I am currently a bit reluctant about changing it as this does not cause any issue with AE2 itself and it is a breaking change. So at least it will not be happening in rv2 anymore. We might change it with rv3, but that is really tentative as it will break existing patterns and people usually do not read the changelogs.

Also the inconsistency in their behaviour and thus breaking it, is introduced by GT.

Member

yueh commented Jul 17, 2015

Looks like the different seeds are handled differently, but each type is still behaves consistent.

I am currently a bit reluctant about changing it as this does not cause any issue with AE2 itself and it is a breaking change. So at least it will not be happening in rv2 anymore. We might change it with rv3, but that is really tentative as it will break existing patterns and people usually do not read the changelogs.

Also the inconsistency in their behaviour and thus breaking it, is introduced by GT.

@yueh yueh added this to the rv3 - 1.7.10 milestone Jul 17, 2015

@lordjoda

This comment has been minimized.

Show comment
Hide comment
@lordjoda

lordjoda Jul 18, 2015

I can understand your reluctance to do it right a way. I had hoped there might be a not breaking option.

I can understand your reluctance to do it right a way. I had hoped there might be a not breaking option.

@yueh

This comment has been minimized.

Show comment
Hide comment
@yueh

yueh Jul 18, 2015

Member

Which for now would be to not let GT mess with it at all. (Which is in general a good idea to not break stuff)

Member

yueh commented Jul 18, 2015

Which for now would be to not let GT mess with it at all. (Which is in general a good idea to not break stuff)

@lordjoda lordjoda referenced this issue in Blood-Asp/GT5-Unofficial Jul 18, 2015

Closed

AE2 Seeds Problem with GregTech #91

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Jul 22, 2015

@yueh yueh closed this in #1732 Jul 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment