Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AE2 Seeds Problem with GregTech #1718

Closed
lordjoda opened this issue Jul 17, 2015 · 9 comments
Closed

AE2 Seeds Problem with GregTech #1718

lordjoda opened this issue Jul 17, 2015 · 9 comments

Comments

@lordjoda
Copy link

@lordjoda lordjoda commented Jul 17, 2015

I already posted the issue at Blood-Asp/GT5-Unofficial#91 but since it seems GregTech is not directly involved in it, I want to mention it here again:
When crafting Fluix or Netherquarz seeds they are displayed and recognized as a different item then the crafting logic expects and therefore the autocrafting logic breaks. Tested with only ae2-rv2-stable9 and gt-5.08.24 and IC2-2.2.746 and default configs.
As seen in the other issue thread, the crafting recipe doesn't have a nbt tag "progress" but for whatever reason the crafted item has (immediately). Certus Quarz Seeds apparently don't have this issue.
If I can provide further Information please let me know!
ae2bug

@yueh
Copy link
Member

@yueh yueh commented Jul 17, 2015

If I recall correctly, does GT not replace these and the certus ore with its own version?

@lordjoda
Copy link
Author

@lordjoda lordjoda commented Jul 17, 2015

No the seeds are not replaced. The only "problem" really is the nbt tag

@yueh
Copy link
Member

@yueh yueh commented Jul 17, 2015

Both spawned through creative and crafted ones have a NBT tag, when I try to reproduce it.

@lordjoda
Copy link
Author

@lordjoda lordjoda commented Jul 17, 2015

Well yes indeed, but in the crafting recipe (so basically what the crafting logic searches for) it is not.

@yueh
Copy link
Member

@yueh yueh commented Jul 17, 2015

The crafting handler is resolving it including the NBT tag. So if this is missing, something is messing with the crafting handler.

@lordjoda
Copy link
Author

@lordjoda lordjoda commented Jul 17, 2015

Hmm but from my tests its the opposite way:
Without GT:

  • Crafted item has no NBT Tag
  • Crafting recipe has no NBT Tag

With GT
-Crafted item has NBT Tag
-Crafting recipe has no NBT Tag

(The item on slot 1 is freshly crafted without gt and "stacks" with the recipe, the other 5 items where crafted with gt installed and do not stack with the recipe even without gt beeing present)
nbt

@yueh
Copy link
Member

@yueh yueh commented Jul 17, 2015

Looks like the different seeds are handled differently, but each type is still behaves consistent.

I am currently a bit reluctant about changing it as this does not cause any issue with AE2 itself and it is a breaking change. So at least it will not be happening in rv2 anymore. We might change it with rv3, but that is really tentative as it will break existing patterns and people usually do not read the changelogs.

Also the inconsistency in their behaviour and thus breaking it, is introduced by GT.

@yueh yueh added this to the rv3 - 1.7.10 milestone Jul 17, 2015
@lordjoda
Copy link
Author

@lordjoda lordjoda commented Jul 18, 2015

I can understand your reluctance to do it right a way. I had hoped there might be a not breaking option.

@yueh
Copy link
Member

@yueh yueh commented Jul 18, 2015

Which for now would be to not let GT mess with it at all. (Which is in general a good idea to not break stuff)

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Jul 22, 2015
@yueh yueh closed this in #1732 Jul 25, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.