New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PneumaticCraft P2P tunnel part #1726

Closed
MineMaarten opened this Issue Jul 20, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@MineMaarten

I was looking into adding P2P support for PneumaticCraft. After looking into the AE2 source it seemed not doable through the API. As OpenComputers also has PR-ed in their P2P tunnel implementation, I was thinking I could try and do the same :).

Let me know what you think, if you guys still want to support additions like this in the 1.7 branch and such. And if you'd like me to PR it, for which branch (master or rv2)?

@yueh

This comment has been minimized.

Show comment
Hide comment
@yueh

yueh Jul 21, 2015

Member

Yes currently not supported by the API, we would also need to ASM transform them onto our base.
We plan to add a real registry to the API for it, but I slightly fear transforming random stuff can go horribly wrong.

Not sure about integrating it currently, most likely need to discuss it with @thatsIch.
But our current stance is mostly to not include mod specific P2P tunnels. That is for example the reason why do not support something like Mekanism gas as this could in general be done with fluids.

OC is a bit special here as there does not exist something like a common network protocol to communicate in a heterogeneous network. If it would, I am pretty sure we would drop the OC support in favor of it.

If it would be ok, then master as target. rv2 is in feature freeze.

Member

yueh commented Jul 21, 2015

Yes currently not supported by the API, we would also need to ASM transform them onto our base.
We plan to add a real registry to the API for it, but I slightly fear transforming random stuff can go horribly wrong.

Not sure about integrating it currently, most likely need to discuss it with @thatsIch.
But our current stance is mostly to not include mod specific P2P tunnels. That is for example the reason why do not support something like Mekanism gas as this could in general be done with fluids.

OC is a bit special here as there does not exist something like a common network protocol to communicate in a heterogeneous network. If it would, I am pretty sure we would drop the OC support in favor of it.

If it would be ok, then master as target. rv2 is in feature freeze.

@Entoarox

This comment has been minimized.

Show comment
Hide comment
@Entoarox

Entoarox Jul 24, 2015

@yueh You could implement the PneumaticCraft p2p as a generic 'pressure' p2p, even if as far as I know MineMaarten is currently the only one actively using pressure in this fashion.

@yueh You could implement the PneumaticCraft p2p as a generic 'pressure' p2p, even if as far as I know MineMaarten is currently the only one actively using pressure in this fashion.

@yueh yueh added the type-feature label Aug 1, 2015

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Aug 5, 2015

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Aug 5, 2015

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Aug 5, 2015

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Aug 5, 2015

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Aug 5, 2015

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Aug 5, 2015

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Aug 5, 2015

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Aug 5, 2015

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Aug 6, 2015

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Aug 6, 2015

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Aug 6, 2015

@yueh yueh added this to the rv3 - 1.7.10 milestone Aug 8, 2015

@yueh yueh self-assigned this Aug 8, 2015

@yueh yueh closed this in #1769 Aug 15, 2015

yueh added a commit that referenced this issue Aug 15, 2015

Merge pull request #1769 from yueh/feature-1726
Closes #1726: Added Pressure P2P tunnel (PneumaticCraft)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment