Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some recipes are not working with rv3 #1791

Closed
yueh opened this issue Aug 11, 2015 · 2 comments
Closed

Some recipes are not working with rv3 #1791

yueh opened this issue Aug 11, 2015 · 2 comments
Labels
Milestone

Comments

@yueh
Copy link
Member

@yueh yueh commented Aug 11, 2015

Some recipes are currently not working, for example this applies to the ME Terminal, Network Tool and nether quartz tools (but not certus ones)

I currently cannot see any pattern or issue causing it, but it seems to be related to oredict or group ingredients. For example the recipes for the quartz tools are identical, just use different oredict entries (for certus/nether quartz)

@thatsIch Could you maybe look into it? You should be a bit more familiar with the recipe handling.

@yueh yueh added the bug label Aug 11, 2015
@yueh yueh added this to the rv3 - 1.7.10 milestone Aug 11, 2015
@yueh
Copy link
Member Author

@yueh yueh commented Aug 11, 2015

Ok it seems to be related to #1635 and that the alias entries are missing. Adding them will fix it for SMP/SSP but not indev.

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Aug 15, 2015
The recipes are now structured into multipe subfolder and split into more
distinct files, so the names are more appropriate and are better at
hinting which items the actually contain.

It also extends the RecipeResourceCopier to now handle the folder
recursively and extract all subdirectories and their files.

"import=" is currently requiring a relative path to the root directory
of the recipes. This would require a larger rewrite/refactoring, thus it
is kept for now until a potentially later changer.

This reverts splitting the oredict entries into their own directory and
moves them back into the recipes folder, as it currently is causing a
couple of issues like not being able to resolve the aliases or is not
working indev. But to keep it seperate it is now its own recipe file.

Fixes AppliedEnergistics#1791
Reverts AppliedEnergistics#1635
yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Aug 15, 2015
The recipes are now structured into multipe subfolder and split into more
distinct files, so the names are more appropriate and are better at
hinting which items the actually contain.

It also extends the RecipeResourceCopier to now handle the folder
recursively and extract all subdirectories and their files.

"import=" is currently requiring a relative path to the root directory
of the recipes. This would require a larger rewrite/refactoring, thus it
is kept for now until a potentially later changer.

This reverts splitting the oredict entries into their own directory and
moves them back into the recipes folder, as it currently is causing a
couple of issues like not being able to resolve the aliases or is not
working indev. But to keep it seperate it is now its own recipe file.

Fixes AppliedEnergistics#1791
Reverts AppliedEnergistics#1635
yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Aug 15, 2015
The recipes are now structured into multipe subfolder and split into more
distinct files, so the names are more appropriate and are better at
hinting which items the actually contain.

It also extends the RecipeResourceCopier to now handle the folder
recursively and extract all subdirectories and their files.

"import=" is currently requiring a relative path to the root directory
of the recipes. This would require a larger rewrite/refactoring, thus it
is kept for now until a potentially later changer.

This reverts splitting the oredict entries into their own directory and
moves them back into the recipes folder, as it currently is causing a
couple of issues like not being able to resolve the aliases or is not
working indev. But to keep it seperate it is now its own recipe file.

Fixes AppliedEnergistics#1791
Reverts AppliedEnergistics#1635
yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Aug 15, 2015
The recipes are now structured into multipe subfolder and split into more
distinct files, so the names are more appropriate and are better at
hinting which items the actually contain.

It also extends the RecipeResourceCopier to now handle the folder
recursively and extract all subdirectories and their files.

"import=" is currently requiring a relative path to the root directory
of the recipes. This would require a larger rewrite/refactoring, thus it
is kept for now until a potentially later changer.

This reverts splitting the oredict entries into their own directory and
moves them back into the recipes folder, as it currently is causing a
couple of issues like not being able to resolve the aliases or is not
working indev. But to keep it seperate it is now its own recipe file.

Fixes AppliedEnergistics#1791
Reverts AppliedEnergistics#1635
@yueh yueh added the fixed label Aug 15, 2015
yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Aug 16, 2015
The recipes are now structured into multipe subfolder and split into more
distinct files, so the names are more appropriate and are better at
hinting which items the actually contain.

It also extends the RecipeResourceCopier to now handle the folder
recursively and extract all subdirectories and their files.

"import=" is currently requiring a relative path to the root directory
of the recipes. This would require a larger rewrite/refactoring, thus it
is kept for now until a potentially later changer.

This reverts splitting the oredict entries into their own directory and
moves them back into the recipes folder, as it currently is causing a
couple of issues like not being able to resolve the aliases or is not
working indev. But to keep it seperate it is now its own recipe file.

Fixes AppliedEnergistics#1791
Reverts AppliedEnergistics#1635
@looogin
Copy link

@looogin looogin commented Aug 16, 2015

ME Terminal do not crafting in App rv3_a4

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Aug 20, 2015
The recipes are now structured into multipe subfolder and split into more
distinct files, so the names are more appropriate and are better at
hinting which items the actually contain.

It also extends the RecipeResourceCopier to now handle the folder
recursively and extract all subdirectories and their files.

"import=" is currently requiring a relative path to the root directory
of the recipes. This would require a larger rewrite/refactoring, thus it
is kept for now until a potentially later changer.

This reverts splitting the oredict entries into their own directory and
moves them back into the recipes folder, as it currently is causing a
couple of issues like not being able to resolve the aliases or is not
working indev. But to keep it seperate it is now its own recipe file.

Fixes AppliedEnergistics#1791
Reverts AppliedEnergistics#1635
yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Aug 21, 2015
The recipes are now structured into multipe subfolder and split into more
distinct files, so the names are more appropriate and are better at
hinting which items the actually contain.

It also extends the RecipeResourceCopier to now handle the folder
recursively and extract all subdirectories and their files.

"import=" is currently requiring a relative path to the root directory
of the recipes. This would require a larger rewrite/refactoring, thus it
is kept for now until a potentially later changer.

This reverts splitting the oredict entries into their own directory and
moves them back into the recipes folder, as it currently is causing a
couple of issues like not being able to resolve the aliases or is not
working indev. But to keep it seperate it is now its own recipe file.

Fixes AppliedEnergistics#1791
Reverts AppliedEnergistics#1635
@yueh yueh closed this in #1805 Aug 22, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.