Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface with Crafting Card stops filling 1 craft short if there's no storage for the item #1833

Closed
octocynth opened this issue Aug 25, 2015 · 1 comment
Labels

Comments

@octocynth
Copy link

@octocynth octocynth commented Aug 25, 2015

Telling an Interface to stock items and give it a Crafting Card, on a network that has no storage for the stocked item causes some strange behavior. (For this test, I was attempting to stock 32 Stone Bricks).

  • The interface gets 28 of the 32 Stone Bricks as expected. Then it stops filling.
  • The interface on the Molecular Assembler accumulates Stone Bricks indefinitely.

Expected behavior was that 32 Stone Bricks would be crafted and sent to the interface, and then crafting would stop.

This is in an SSP world using only AE2.
Gallery of screenshots and other information

@yueh yueh added the type-bug label Aug 25, 2015
@yueh
Copy link
Member

@yueh yueh commented Aug 25, 2015

Caused by the order in CraftingCPUCluster.java#L293-L303.

completeJob() will invalidate the crafting link, but this is required by the interface to accept the items.
Moving injectItems() to the front does fix it, but I am currently not completely certain how it handles the left over itemstack, as changing it will not make it a simple return injectItems() (Should you want to take a look @thatsIch)

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Aug 28, 2015
@yueh yueh closed this in #1839 Sep 5, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.