Interface with Crafting Card stops filling 1 craft short if there's no storage for the item #1833

Closed
endreman0 opened this Issue Aug 25, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@endreman0

Telling an Interface to stock items and give it a Crafting Card, on a network that has no storage for the stocked item causes some strange behavior. (For this test, I was attempting to stock 32 Stone Bricks).

  • The interface gets 28 of the 32 Stone Bricks as expected. Then it stops filling.
  • The interface on the Molecular Assembler accumulates Stone Bricks indefinitely.

Expected behavior was that 32 Stone Bricks would be crafted and sent to the interface, and then crafting would stop.

This is in an SSP world using only AE2.
Gallery of screenshots and other information

@yueh yueh added the type-bug label Aug 25, 2015

@yueh

This comment has been minimized.

Show comment
Hide comment
@yueh

yueh Aug 25, 2015

Member

Caused by the order in CraftingCPUCluster.java#L293-L303.

completeJob() will invalidate the crafting link, but this is required by the interface to accept the items.
Moving injectItems() to the front does fix it, but I am currently not completely certain how it handles the left over itemstack, as changing it will not make it a simple return injectItems() (Should you want to take a look @thatsIch)

Member

yueh commented Aug 25, 2015

Caused by the order in CraftingCPUCluster.java#L293-L303.

completeJob() will invalidate the crafting link, but this is required by the interface to accept the items.
Moving injectItems() to the front does fix it, but I am currently not completely certain how it handles the left over itemstack, as changing it will not make it a simple return injectItems() (Should you want to take a look @thatsIch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment