New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import bus not respecting the storable amount when importing. #1892

Closed
maxpoulin64 opened this Issue Sep 21, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@maxpoulin64

maxpoulin64 commented Sep 21, 2015

(Yes, I really wrote import bus)

I made a processor setup using inscribers and storage buses, where each inscriber has a storage bus with a filter as the input, and an import bus as the output. Pretty simple. However, from time to time, it gets jammed because one of the printed circuits ends up back in the inscriber's middle slot, which shouldn't happen because the storage bus is configured to only accept the correct items (ie. silicon, gold, pure certus or diamonds) and the only other thing connected to the inscriber is an import bus.

storage-bus
bus-config

After further investigation, it appears that:

  • The last inscriber on the line (the one that assembles printed circuits into processors) needs to be running for the issue to present itself.
  • Removing the storage buses on the first 4 inscribers doesn't make the issue go away.
  • Adding a controller and making it all one network also fixes the issue.

I suspect the import bus pulls the items from the inscriber, tries to put it into the other network through the storage bus + interface combo, fails to do so because, and then tries to push it back into the inscriber. Since the sides of the inscriber puts items in the middle slot and not the output slot, the printed circuit ends back in the middle slot instead of the output slot where it comes from. Additionally, if there's items in the middle slot, the printed circuit is destroyed and lost in the process.

Happens in both rv2.stable build 10 and rv3.alpha build 6 downloaded less than an hour ago. AE is the only mod loaded, using the latest recommended forge (10.13.4.1448). Reproduced both in single player and multiplayer.

Video (on server): http://d.max-p.me/temp/irc/ftb/inscriber.mp4
Video (import bus alone): http://d.max-p.me/temp/irc/ftb/inscriber-2.mp4
World save exposing the issue: http://d.max-p.me/temp/irc/ftb/Inscriber.zip

@yueh yueh changed the title from Import bus inserts items in the wrong spot of inscribers to Import bus not respecting the storable amount when importing. Sep 22, 2015

@yueh yueh added the type-bug label Sep 22, 2015

@yueh

This comment has been minimized.

Show comment
Hide comment
@yueh

yueh Sep 22, 2015

Member

Import buses currently do not respect what amount is actually storable inside the network before extracting something and try to put these items back into the inventory they extracted it from.

If this is inventory is somehow restricted in what they accept (say invalid input), it will simply fail to do so.
In case of chests and similar things this works perfectly, but even furnaces could be an issue.

For your usecase the best option to prevent it for now is simply do not use acceleration cards, they will not even provide any speedup in your setup or give it a location to store any overflow.

Member

yueh commented Sep 22, 2015

Import buses currently do not respect what amount is actually storable inside the network before extracting something and try to put these items back into the inventory they extracted it from.

If this is inventory is somehow restricted in what they accept (say invalid input), it will simply fail to do so.
In case of chests and similar things this works perfectly, but even furnaces could be an issue.

For your usecase the best option to prevent it for now is simply do not use acceleration cards, they will not even provide any speedup in your setup or give it a location to store any overflow.

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Sep 22, 2015

Fixes incorrect handling of prioritized inventories
Prioritized inventories are not longer used twice for storing leftover
items and thus finally reporting twice the amount of storable items when
they are the only possible option to store something.

Also fixes import buses now respecting the amount of storable items inside
the network instead of trying to place the exported items back and failing
on any restricted inventory, potentially voiding the overflow.

Fixes #1892

@yueh yueh added the state-fixed label Sep 22, 2015

@yueh

This comment has been minimized.

Show comment
Hide comment
@yueh

yueh Sep 22, 2015

Member

Actually even two bugs.
The import bus not testing how much it can actually import and prioritized inventories (for example storage buses with a whitelist) were traversed twice as potential storage location.

I would say it is even a duplicate of #1507.
A great example how a good issue description makes the difference between fixing it in like an hour vs. dismissing it as an user error.

Thanks a lot for it.

Member

yueh commented Sep 22, 2015

Actually even two bugs.
The import bus not testing how much it can actually import and prioritized inventories (for example storage buses with a whitelist) were traversed twice as potential storage location.

I would say it is even a duplicate of #1507.
A great example how a good issue description makes the difference between fixing it in like an hour vs. dismissing it as an user error.

Thanks a lot for it.

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Sep 22, 2015

Fixes incorrect handling of prioritized inventories
Prioritized inventories are not longer used twice for storing leftover
items and thus finally reporting twice the amount of storable items when
they are the only possible option to store something.

Also fixes import buses now respecting the amount of storable items inside
the network instead of trying to place the exported items back and failing
on any restricted inventory, potentially voiding the overflow.

Fixes #1892

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Sep 22, 2015

Fixes incorrect handling of prioritized inventories
Prioritized inventories are not longer used twice for storing leftover
items and thus finally reporting twice the amount of storable items when
they are the only possible option to store something.

Also fixes import buses now respecting the amount of storable items inside
the network instead of trying to place the exported items back and failing
on any restricted inventory, potentially voiding the overflow.

Fixes #1892

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Sep 23, 2015

Fixes incorrect handling of prioritized inventories
Prioritized inventories are not longer used twice for storing leftover
items and thus finally reporting twice the amount of storable items when
they are the only possible option to store something.

Also fixes import buses now respecting the amount of storable items inside
the network instead of trying to place the exported items back and failing
on any restricted inventory, potentially voiding the overflow.

Fixes #1892

@yueh yueh closed this in #1893 Sep 23, 2015

@yueh yueh added this to the rv3 - 1.7.10 milestone Dec 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment