New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Buses not respecting failed crafting requests #1905

Closed
yueh opened this Issue Sep 25, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@yueh
Member

yueh commented Sep 25, 2015

Export buses do not consider failed crafting requests when adjusting their dynamic tickrate.
If a certain amount of request failed, they should slow down instead of up, which will happen when just one request did succeed.

The best approach would be use a counter, which gets increase by one for every failed request and decreased by one for every successful, and above certain thresholds no longer increase the speed or even slow them down.

Related to #1904

@yueh yueh added this to the rv3 - 1.7.10 milestone Sep 25, 2015

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Sep 25, 2015

Fixes #1905: Export bus now considers failed crafting requests
The export bus will now no longer speed up, if more than 1 of the last
crafting requests failed and slow down, if more then 5 failed.

Some code cleanup and moved the custom iterator into the helper package
as it is clearly related to the craftingtracker and not the export bus.

@yueh yueh closed this in #1907 Sep 26, 2015

yueh added a commit that referenced this issue Sep 26, 2015

Merge pull request #1907 from yueh/fix-1905
Fixes #1905: Export bus now considers failed crafting requests

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Dec 26, 2015

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Dec 26, 2015

Interfaces now slow down with failed crafting attempts.
Cleanup of unneeded tracking of failed attempts of MultiCraftingTracker.
Followup of #1905

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Dec 26, 2015

Interfaces now slow down with failed crafting attempts.
Cleanup of unneeded tracking of failed attempts of MultiCraftingTracker.
Followup of #1905

yueh added a commit that referenced this issue Jan 1, 2016

Interfaces now slow down with failed crafting attempts.
Cleanup of unneeded tracking of failed attempts of MultiCraftingTracker.
Followup of #1905
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment