VersionChecker unhandled exceptions #1932

Closed
DestinyPlayer opened this Issue Oct 4, 2015 · 6 comments

Comments

Projects
None yet
3 participants
@DestinyPlayer

My friend has that weird freeze issue. From what he sees, there's some weird exception in AE2 VersionChecker which freezes his game dead stop.
https://dl.dropboxusercontent.com/u/77108893/Crash%20Reports/AE2%20log.txt

@yueh yueh changed the title from Weird freeze issue to VersionChecker unhandled exceptions Oct 5, 2015

@yueh

This comment has been minimized.

Show comment
Hide comment
@yueh

yueh Oct 5, 2015

Member

This is just a notice created by the JVM, but no case for any freeze.
But we should really have a better exception handling for invalid version configurations.

Member

yueh commented Oct 5, 2015

This is just a notice created by the JVM, but no case for any freeze.
But we should really have a better exception handling for invalid version configurations.

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Oct 5, 2015

Fixes #1932: Better VersionChecker exception handling
ModVersionFetcher will now return a MissingVersion in case of an exception
instead of letting it propagate upwards.

Also added a generic try/catch to the VersionChecker itself, just in case
any unchecked exception might be triggered inside the thread and at least
not logged correctly.

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Oct 5, 2015

Fixes #1932: Better VersionChecker exception handling
ModVersionFetcher will now return a MissingVersion in case of an exception
instead of letting it propagate upwards.

Also added a generic try/catch to the VersionChecker itself, just in case
any unchecked exception might be triggered inside the thread and at least
not logged correctly.
@DestinyPlayer

This comment has been minimized.

Show comment
Hide comment
@DestinyPlayer

DestinyPlayer Oct 5, 2015

But still, there's still some weird dead-freeze issue. Are you sure it's not due to AE2? Any ideas what might cause it? Because the game constantly freezes up for my friend right after that message.

But still, there's still some weird dead-freeze issue. Are you sure it's not due to AE2? Any ideas what might cause it? Because the game constantly freezes up for my friend right after that message.

@yueh

This comment has been minimized.

Show comment
Hide comment
@yueh

yueh Oct 5, 2015

Member

Yes, the version checker intentionally runs inside its own thread to prevent it from affecting the main minecraft one. It is even marked with a low priority, in case the JVM wants to defer the execution in case it is heavily loaded.

It is probably just the last entry, because the JVM probably decided to stop the thread and just adds this notice to the log. There are also a couple of other exceptions logged, like the ones from Witching WitchingGadgets.
But I would consider JourneyMap as possible offender, it immediately started a second earlier and I had similar issues with it myself until it has finished the rendering. As far is I remember it is also multithreaded, so this might be the cause why the JVM stopped our version checker at this moment.

Member

yueh commented Oct 5, 2015

Yes, the version checker intentionally runs inside its own thread to prevent it from affecting the main minecraft one. It is even marked with a low priority, in case the JVM wants to defer the execution in case it is heavily loaded.

It is probably just the last entry, because the JVM probably decided to stop the thread and just adds this notice to the log. There are also a couple of other exceptions logged, like the ones from Witching WitchingGadgets.
But I would consider JourneyMap as possible offender, it immediately started a second earlier and I had similar issues with it myself until it has finished the rendering. As far is I remember it is also multithreaded, so this might be the cause why the JVM stopped our version checker at this moment.

@thatsIch

This comment has been minimized.

Show comment
Hide comment
@thatsIch

thatsIch Oct 6, 2015

Member

I would wonder more why the stable is not matching with either alpha, beta or stable. I do not see any code flaw regarding that logic issue.

also your EventBus overflowed which is there for stitching the textures together.

Member

thatsIch commented Oct 6, 2015

I would wonder more why the stable is not matching with either alpha, beta or stable. I do not see any code flaw regarding that logic issue.

also your EventBus overflowed which is there for stitching the textures together.

@yueh

This comment has been minimized.

Show comment
Hide comment
@yueh

yueh Oct 6, 2015

Member

Probably due to #1521

Member

yueh commented Oct 6, 2015

Probably due to #1521

@thatsIch

This comment has been minimized.

Show comment
Hide comment
@thatsIch

thatsIch Oct 6, 2015

Member

oh my, that was ages ago.
Why was that not pulled onto the stable?

Member

thatsIch commented Oct 6, 2015

oh my, that was ages ago.
Why was that not pulled onto the stable?

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Oct 8, 2015

Fixes #1932: Better VersionChecker exception handling
ModVersionFetcher will now return a MissingVersion in case of an exception
instead of letting it propagate upwards.

Also added a generic try/catch to the VersionChecker itself, just in case
any unchecked exception might be triggered inside the thread and at least
not logged correctly.

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Oct 8, 2015

Fixes #1932: Better VersionChecker exception handling
ModVersionFetcher will now return a MissingVersion in case of an exception
instead of letting it propagate upwards.

Also added a generic try/catch to the VersionChecker itself, just in case
any unchecked exception might be triggered inside the thread and at least
not logged correctly.

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Oct 8, 2015

Fixes #1932: Better VersionChecker exception handling
ModVersionFetcher will now return a MissingVersion in case of an exception
instead of letting it propagate upwards.

Also added a generic try/catch to the VersionChecker itself, just in case
any unchecked exception might be triggered inside the thread and at least
not logged correctly.

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Oct 8, 2015

Fixes #1932: Better VersionChecker exception handling
ModVersionFetcher will now return a MissingVersion in case of an exception
instead of letting it propagate upwards.

Also added a generic try/catch to the VersionChecker itself, just in case
any unchecked exception might be triggered inside the thread and at least
not logged correctly.

@yueh yueh closed this in 47592bc Oct 21, 2015

yueh added a commit that referenced this issue Oct 21, 2015

Merge pull request #1934 from yueh/fix-1932
Fixes #1932: Better VersionChecker exception handling

yueh added a commit that referenced this issue Dec 24, 2015

Fixes #1932: Better VersionChecker exception handling
ModVersionFetcher will now return a MissingVersion in case of an exception
instead of letting it propagate upwards.

Also added a generic try/catch to the VersionChecker itself, just in case
any unchecked exception might be triggered inside the thread and at least
not logged correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment