Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering of a press in inscriber leave the GL engine in an improper state #1970

Closed
leagris opened this issue Oct 25, 2015 · 4 comments
Closed

Rendering of a press in inscriber leave the GL engine in an improper state #1970

leagris opened this issue Oct 25, 2015 · 4 comments
Assignees
Milestone

Comments

@leagris
Copy link

@leagris leagris commented Oct 25, 2015

When displaying a press, the inscriber leave the GL engine in an improper state causing ambient occlusion to not render at some angles.

Look at toolrack render differences (top-right of pictures)
Without press in inscriber:
2015-10-25_23 48 58
With press in inscriber:
2015-10-25_23 49 23

See also:
ForestryMC/ForestryMC#919

@yueh
Copy link
Member

@yueh yueh commented Oct 25, 2015

Anything printed to the log? For example a GL Stackoverflow?

The rendering is actually stupidly over conservative, especially once it needs to render an item (like the press). Like the renderer tries to protect itself from any buggy item render and simultaneously the item renderer protects itself from any buggy caller (which actually is guaranteed AE2), thus really useless. But this easily can result in some stackoverflows etc. Too conservative/defensive is just as bad as too less... Finding an equilibrium is not that easy.

Out of curiositiy, could you try the PR build based on #1880?
It removes most of the extreme defensive stuff and in general is a bit more selective about what state it protects (which should also result in a better performance in some cases, like ridiculuous amounts of skystone chests.
Build against rv3, but it seems you are already using it. But as usually make backups.
Nevertheless it should be mostly finished, just need to test it a bit more (or get some feedback)

@thatsIch
Copy link
Member

@thatsIch thatsIch commented Nov 11, 2015

While working on this I noticed a few other bugs, this is fixed internally

@thatsIch thatsIch self-assigned this Nov 11, 2015
@thatsIch thatsIch added this to the rv3 - 1.7.10 milestone Nov 11, 2015
@yueh
Copy link
Member

@yueh yueh commented Nov 11, 2015

Based on my PR or the current master? I had a couple of small rendering issues, mostly lighting based on, which are fixed with the PR. Just to prevent any duplicate work.

@thatsIch
Copy link
Member

@thatsIch thatsIch commented Nov 11, 2015

Always on master, also if it is on your PR you would see your commit in it

@thatsIch thatsIch closed this in 97c099c Nov 16, 2015
yueh added a commit that referenced this issue Nov 16, 2015
Fixes #1970: Lighting was not re-enabled when looking at an inscriber
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.