Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage math - no difference between cells #225

Closed
fgoebel opened this issue Oct 1, 2014 · 14 comments
Closed

Storage math - no difference between cells #225

fgoebel opened this issue Oct 1, 2014 · 14 comments
Assignees
Milestone

Comments

@fgoebel
Copy link

@fgoebel fgoebel commented Oct 1, 2014

Hello there!

  • The problem that is happening?
    • Today i noticed that there is no difference with the bytes used between the different storage cells.
  • What was expected?
    • In the Wiki it says that there is more space used for storing the type, the bigger the cell gets.
      For me it is always 8bytes /type, no matter which storage cell.
  • Server or Single Player?
    • both, noticed on multiplayer, then tested in singleplayer with only AE2 v1.stable build 1 installed
  • Screen shots or Pictures of the problem?
    • every Cell contains the same amount of items:
      2014-10-02_00 35 46
    • 1k Storage Cell:
      2014-10-02_00 35 56
    • 4k Storage Cell:
      2014-10-02_00 35 57
    • 16k Storage Cell:
      2014-10-02_00 35 58
    • 64k Storage Cell:
      2014-10-02_00 36 00

Hope this Helps!

Thank you for this awesome mod!! keep up the good work! Thank you!

@MrMetric
Copy link
Contributor

@MrMetric MrMetric commented Oct 2, 2014

I can't speak for the devs, but that seems like intended behavior to me. I dunno why the storage math page says otherwise. A 1 MB file doesn't take up any more space on a 600 GB HDD than on a 30 GB HDD.

@Cisien
Copy link
Contributor

@Cisien Cisien commented Oct 2, 2014

the behavior you are reporting is correct.

i think the documentation was trying to say that you will run out of types before you run out of bytes.

@Cisien Cisien closed this Oct 2, 2014
@thatsIch
Copy link
Member

@thatsIch thatsIch commented Oct 2, 2014

That is actually a bug.

@thatsIch thatsIch reopened this Oct 2, 2014
@thatsIch
Copy link
Member

@thatsIch thatsIch commented Oct 2, 2014

@iloveportalz0r and its meant for that because, it requires a larger overhead to manage that file. Like NTFS and FAT32.

@thatsIch thatsIch added the bug label Oct 2, 2014
@thatsIch thatsIch added this to the rv2 milestone Oct 2, 2014
@thatsIch
Copy link
Member

@thatsIch thatsIch commented Oct 2, 2014

Look here as reference: http://ae-mod.info/64k-ME-Storage-Cell/

The 64k Storage Cell uses 512 bytes of data to store a single type

@hisorange
Copy link

@hisorange hisorange commented Oct 2, 2014

This was fixed before, I was the one who reported it like 2 month ago.

@thatsIch
Copy link
Member

@thatsIch thatsIch commented Oct 2, 2014

Must have sneaked in somehow again
Anyways I fixed it in #226

@thatsIch thatsIch self-assigned this Oct 2, 2014
@thatsIch thatsIch closed this in 03047e4 Oct 2, 2014
FireBall1725 added a commit that referenced this issue Oct 2, 2014
Fixed #225 Not returning correct size per type of 8, 32, 128, 512 instead of constant 8 in BytesPerType
@Cisien
Copy link
Contributor

@Cisien Cisien commented Oct 2, 2014

ahh, never knew that.

@MrMetric
Copy link
Contributor

@MrMetric MrMetric commented Oct 2, 2014

What happens if I load a world with the new build? Will it delete any items from my cells?

@Cisien
Copy link
Contributor

@Cisien Cisien commented Oct 2, 2014

I'll test later this evening.

@UndeadZeratul
Copy link

@UndeadZeratul UndeadZeratul commented Oct 2, 2014

Can this be configurable? Maybe have configs per cell tier for item type size in bytes and max number of item types within a cell?

@thatsIch
Copy link
Member

@thatsIch thatsIch commented Oct 2, 2014

could, but no, in the spirit of AE2
also changing that would result into other problems like GUIs and such, CellWorkbench has only 63 types at max.

@Cisien
Copy link
Contributor

@Cisien Cisien commented Oct 4, 2014

items won't be lost with this change. The cell will store more than it should, though..

http://paste.cisien.com/f/bd6afc1.png

@yueh
Copy link
Member

@yueh yueh commented Oct 4, 2014

That is only temporary. It won't store anything new until it drops below the threshold.
But it can result in storages being completely full and causing issues with this.
Maybe rv2 beta/stable should have some indication of it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants
You can’t perform that action at this time.