Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
@jztech101 ran into an NPE on the line above the commented one. Not really sure what's causing it though. I have a feeling it has to do with rv1 stuff that we need to migrate to the correct spellings (the renamed/fixed enum names getting written to NBT as their .toString() value.)
I think I have a better option. At the moment it determines the expected setting by the NBT tag itself within the item. In itself it is not bad but as you see, any renaming to it leads to crashing code. The system should be more like config system from Forge.
It tries to fetch a specific tag from the config and if not present set the value with a default value. That way it can never occur, that it crashes without our reach. This will also allow us to remove that rv1 -> rv2 hack to catch those circumstances. In addition to that we can check and remove all non-existent tags stored to that item. Not really needed imo in the long run, but can prevent cluttering of the NBT tags.