Crash server when AE is out of energy #2714

Closed
MaxGaming63 opened this Issue Dec 20, 2016 · 5 comments

Projects

None yet

4 participants

@MaxGaming63

When my AE is out of energy, my server has a crash.

http://pastebin.com/xDdB0x2e

  • Minecraft Version: 1.10.2
  • AE2 Version: rv4 alpha 8
  • Forge Version: forge-12.18.2.2151
@yueh
Member
yueh commented Dec 20, 2016

This is probably the confirmation, that we actually have to create a copy and cannot use the approach of #2496.

If you can reproduce it easily, can you please try the build from #2715? Once jenkins is done.

@yueh yueh added the type-bug label Dec 20, 2016
@yueh yueh added this to the rv4 beta - 1.10 milestone Dec 20, 2016
@Xiaminou
Xiaminou commented Dec 22, 2016 edited

it worked... (maybe)

@yueh
Member
yueh commented Dec 23, 2016

Not maybe, we did intentionally change to test, if the old implementation was necessary or not. Now we know it, but at least it should be faster using an CopyOnWriteArrayList compared to the old implementation, which was backed by a copying a LinkedList.

@yueh yueh closed this in 497f1c9 Dec 29, 2016
@melekaiah

any chance of a release with this fix? i cant really remove the mod and friends just keep forgetting. i keep having to call home to restart our private server.

@Xiaminou

Like Yueh said, you can download it from the Jenkins.

@phit phit added a commit to Stonebound/Applied-Energistics-2 that referenced this issue Jan 1, 2017
@yueh @phit yueh + phit Fixes #2714: Use a concurrent list to back NetworkList (#2715) 26f7a02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment