New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.12] Crafting terminal doesnt remember client-side settings when closing the terminal #2988

Closed
016Nojr opened this Issue Jul 29, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@016Nojr

016Nojr commented Jul 29, 2017

Nothing else to say other than the title

Mod list:
Forge 14.21.1.2426
AE2: rv5-alpha-1

Custom modpack, modlist can be provided if wanted.
Logs can also be provided if wanted

@ProxyPlayerHD

This comment has been minimized.

Show comment
Hide comment
@ProxyPlayerHD

ProxyPlayerHD Jul 31, 2017

any Terminal

not just Crafting... you can test it, i got a GIF as proof

also add to that, sometimes changing the Display settings of the Terimal doesn't change anything
GIF also shows that

GIF

ProxyPlayerHD commented Jul 31, 2017

any Terminal

not just Crafting... you can test it, i got a GIF as proof

also add to that, sometimes changing the Display settings of the Terimal doesn't change anything
GIF also shows that

GIF

@GuntherDW

This comment has been minimized.

Show comment
Hide comment
@GuntherDW

GuntherDW Aug 1, 2017

Contributor

This is on a server I presume? There's stuff that we still need to work out how/why as shown in #2961.
There's been an update in one of the libraries of vanilla/Forge and it changed some underlying methods we relied on.

I added a workaround back then but what is really needed in the long run is a rewrite of the packet system.
The changes in Netty are just bugs waiting to happen.

Contributor

GuntherDW commented Aug 1, 2017

This is on a server I presume? There's stuff that we still need to work out how/why as shown in #2961.
There's been an update in one of the libraries of vanilla/Forge and it changed some underlying methods we relied on.

I added a workaround back then but what is really needed in the long run is a rewrite of the packet system.
The changes in Netty are just bugs waiting to happen.

@016Nojr

This comment has been minimized.

Show comment
Hide comment
@016Nojr

016Nojr Aug 1, 2017

This is in a singleplayer world, but it was working in the version I compiled, will test again in a few hours

016Nojr commented Aug 1, 2017

This is in a singleplayer world, but it was working in the version I compiled, will test again in a few hours

@GuntherDW

This comment has been minimized.

Show comment
Hide comment
@GuntherDW

GuntherDW Aug 3, 2017

Contributor

@ProxyPlayerHD the only time I have been able to effectively reproduce said bug is when the server is skipping ticks due to TPS lag. Also try to keep actual issue reports in an issue down to 1 bug per issue.

I can confirm that the settings do not get stored as they have in the past, with the exception being the wireless terminal.
When I get back to programing I'll take a look at said bug.

Contributor

GuntherDW commented Aug 3, 2017

@ProxyPlayerHD the only time I have been able to effectively reproduce said bug is when the server is skipping ticks due to TPS lag. Also try to keep actual issue reports in an issue down to 1 bug per issue.

I can confirm that the settings do not get stored as they have in the past, with the exception being the wireless terminal.
When I get back to programing I'll take a look at said bug.

@GuntherDW GuntherDW self-assigned this Aug 3, 2017

@GuntherDW GuntherDW closed this in 5abb8bf Aug 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment