Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mystcraft] AE2 Meteor Spawns #316

Closed
CryoScribe opened this issue Oct 17, 2014 · 9 comments
Closed

[Mystcraft] AE2 Meteor Spawns #316

CryoScribe opened this issue Oct 17, 2014 · 9 comments

Comments

@CryoScribe
Copy link

@CryoScribe CryoScribe commented Oct 17, 2014

Posted this to Mystcraft Devs on the Technical Forum, but I am posting this to you guys just in case.
http://binarymage.com/forum/viewtopic.php?f=8&t=2588

Every time I make an Island World age, a meteor spawns smack dab in my island. Makes finding meteors easier, but is annoying.
Screenshot : http://i.imgur.com/Ll6izur.png

Mystcraft Version0.11.0.00
AE2 Version rv-1 beta-32

@thatsIch
Copy link
Member

@thatsIch thatsIch commented Oct 17, 2014

And what are we supposed to do? There will be a dimension ID blacklist soon. Not sure if its fits your need.

@Cisien
Copy link
Contributor

@Cisien Cisien commented Oct 17, 2014

We could blacklist the mystcraft provider (not sure if possible) and then provide a compat module to add meteors as a page in mystcraft (or they can)

@thatsIch
Copy link
Member

@thatsIch thatsIch commented Oct 17, 2014

sounds reasonable

@yueh
Copy link
Member

@yueh yueh commented Oct 17, 2014

A page for mystcraft sounds reasonable, but can be a bit too specific.
If a new mod with a similar functionality shows, we need to add new code to it explicitly.

Does the blacklist also include a whitelist functionality?
The best solution in my opinion would be a config file based whitelist/blacklist and an IMC reciever. This would allow other mods to request disable (enable?) it in a specific dimension. For cases where the dimension id is only available at runtime and a static blacklist is not really an option.

@CryoScribe CryoScribe closed this Oct 17, 2014
@Cisien Cisien reopened this Oct 17, 2014
@Lightwave413
Copy link

@Lightwave413 Lightwave413 commented Oct 18, 2014

I wonder, if you talk to XComp, if you could use the Mystcraft API to prevent Meteorite generation in Ages with the "Island World" or "Skylands" pages. I've also seen a Meteorite in a Void Age once (http://i.imgur.com/sQeG0mK.png), but this was several versions ago, I think.

@yueh
Copy link
Member

@yueh yueh commented Oct 18, 2014

I do not think that either side needing a full API dependency just to disable the spawn is a good idea.

Just considering this for AE2. It might only start with a requirement on the Mystcraft API, but suddenly we need the BoP API, Highlands API, XU API, Witchery API, just each API for every mod which adds its own dimensions.

Providing the blacklist/whitelist through IMC is the better option, but still forces other mods to deal with our worldgen. Best option to prevent this, would probably be using a default whitelist which only containts the overworld.

Overall the best solution would be, if forge would provide something for it. Like forcing any worldgen to be disabled and only explicitly allow our own generators or at least only known 3rd party ones.

@thatsIch
Copy link
Member

@thatsIch thatsIch commented Oct 18, 2014

maybe a white list meteor spawn would be better ^^
probably only overworld and end would be interessting

@Cisien
Copy link
Contributor

@Cisien Cisien commented Oct 18, 2014

the End is already excluded

@Cisien
Copy link
Contributor

@Cisien Cisien commented Oct 19, 2014

@Cisien Cisien closed this Oct 19, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.