New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mystcraft] AE2 Meteor Spawns #316

Closed
CryoScribe opened this Issue Oct 17, 2014 · 9 comments

Comments

Projects
None yet
5 participants
@CryoScribe

CryoScribe commented Oct 17, 2014

Posted this to Mystcraft Devs on the Technical Forum, but I am posting this to you guys just in case.
http://binarymage.com/forum/viewtopic.php?f=8&t=2588

Every time I make an Island World age, a meteor spawns smack dab in my island. Makes finding meteors easier, but is annoying.
Screenshot : http://i.imgur.com/Ll6izur.png

Mystcraft Version0.11.0.00
AE2 Version rv-1 beta-32

@thatsIch

This comment has been minimized.

Show comment
Hide comment
@thatsIch

thatsIch Oct 17, 2014

Member

And what are we supposed to do? There will be a dimension ID blacklist soon. Not sure if its fits your need.

Member

thatsIch commented Oct 17, 2014

And what are we supposed to do? There will be a dimension ID blacklist soon. Not sure if its fits your need.

@Cisien

This comment has been minimized.

Show comment
Hide comment
@Cisien

Cisien Oct 17, 2014

Contributor

We could blacklist the mystcraft provider (not sure if possible) and then provide a compat module to add meteors as a page in mystcraft (or they can)

Contributor

Cisien commented Oct 17, 2014

We could blacklist the mystcraft provider (not sure if possible) and then provide a compat module to add meteors as a page in mystcraft (or they can)

@thatsIch

This comment has been minimized.

Show comment
Hide comment
@thatsIch

thatsIch Oct 17, 2014

Member

sounds reasonable

Member

thatsIch commented Oct 17, 2014

sounds reasonable

@yueh

This comment has been minimized.

Show comment
Hide comment
@yueh

yueh Oct 17, 2014

Member

A page for mystcraft sounds reasonable, but can be a bit too specific.
If a new mod with a similar functionality shows, we need to add new code to it explicitly.

Does the blacklist also include a whitelist functionality?
The best solution in my opinion would be a config file based whitelist/blacklist and an IMC reciever. This would allow other mods to request disable (enable?) it in a specific dimension. For cases where the dimension id is only available at runtime and a static blacklist is not really an option.

Member

yueh commented Oct 17, 2014

A page for mystcraft sounds reasonable, but can be a bit too specific.
If a new mod with a similar functionality shows, we need to add new code to it explicitly.

Does the blacklist also include a whitelist functionality?
The best solution in my opinion would be a config file based whitelist/blacklist and an IMC reciever. This would allow other mods to request disable (enable?) it in a specific dimension. For cases where the dimension id is only available at runtime and a static blacklist is not really an option.

@CryoScribe CryoScribe closed this Oct 17, 2014

@Cisien Cisien reopened this Oct 17, 2014

@Lightwave413

This comment has been minimized.

Show comment
Hide comment
@Lightwave413

Lightwave413 Oct 18, 2014

I wonder, if you talk to XComp, if you could use the Mystcraft API to prevent Meteorite generation in Ages with the "Island World" or "Skylands" pages. I've also seen a Meteorite in a Void Age once (http://i.imgur.com/sQeG0mK.png), but this was several versions ago, I think.

Lightwave413 commented Oct 18, 2014

I wonder, if you talk to XComp, if you could use the Mystcraft API to prevent Meteorite generation in Ages with the "Island World" or "Skylands" pages. I've also seen a Meteorite in a Void Age once (http://i.imgur.com/sQeG0mK.png), but this was several versions ago, I think.

@yueh

This comment has been minimized.

Show comment
Hide comment
@yueh

yueh Oct 18, 2014

Member

I do not think that either side needing a full API dependency just to disable the spawn is a good idea.

Just considering this for AE2. It might only start with a requirement on the Mystcraft API, but suddenly we need the BoP API, Highlands API, XU API, Witchery API, just each API for every mod which adds its own dimensions.

Providing the blacklist/whitelist through IMC is the better option, but still forces other mods to deal with our worldgen. Best option to prevent this, would probably be using a default whitelist which only containts the overworld.

Overall the best solution would be, if forge would provide something for it. Like forcing any worldgen to be disabled and only explicitly allow our own generators or at least only known 3rd party ones.

Member

yueh commented Oct 18, 2014

I do not think that either side needing a full API dependency just to disable the spawn is a good idea.

Just considering this for AE2. It might only start with a requirement on the Mystcraft API, but suddenly we need the BoP API, Highlands API, XU API, Witchery API, just each API for every mod which adds its own dimensions.

Providing the blacklist/whitelist through IMC is the better option, but still forces other mods to deal with our worldgen. Best option to prevent this, would probably be using a default whitelist which only containts the overworld.

Overall the best solution would be, if forge would provide something for it. Like forcing any worldgen to be disabled and only explicitly allow our own generators or at least only known 3rd party ones.

@thatsIch

This comment has been minimized.

Show comment
Hide comment
@thatsIch

thatsIch Oct 18, 2014

Member

maybe a white list meteor spawn would be better ^^
probably only overworld and end would be interessting

Member

thatsIch commented Oct 18, 2014

maybe a white list meteor spawn would be better ^^
probably only overworld and end would be interessting

@Cisien

This comment has been minimized.

Show comment
Hide comment
@Cisien

Cisien Oct 18, 2014

Contributor

the End is already excluded

Contributor

Cisien commented Oct 18, 2014

the End is already excluded

@Cisien

This comment has been minimized.

Show comment
Hide comment
@Cisien

Cisien Oct 19, 2014

Contributor
Contributor

Cisien commented Oct 19, 2014

@Cisien Cisien closed this Oct 19, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment