New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid Patterns cause FPS to drop #3255

Closed
Xiaminou opened this Issue Nov 30, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@Xiaminou

Xiaminou commented Nov 30, 2017

Description

Invalid Patterns cause FPS to drop when pressing shift.
https://youtu.be/Q7r_1cTtbdY

Environment

  • Minecraft Version: 1.12.2
  • AE2 Version: rv5-stable-3
  • Forge Version: 2556
  • Mods: list.txt
@yueh

This comment has been minimized.

Show comment
Hide comment
@yueh

yueh Nov 30, 2017

Member

Cannot really reproduce it indev. There might be a small FPS drop, but that can also be something random as it also fluctuates in the same area witout invalid patterns.

But there is one code path, which might be a bit problematic in combination with some mods and how badly recipes are handled in 1.12 by forge and some mods make it even worse.

I'm just testing a slightly optimized build, but there is no guarantee that it really helps. Outside this particular path, it is just vanilla/forge item rendering. Thus outside of our control.

Member

yueh commented Nov 30, 2017

Cannot really reproduce it indev. There might be a small FPS drop, but that can also be something random as it also fluctuates in the same area witout invalid patterns.

But there is one code path, which might be a bit problematic in combination with some mods and how badly recipes are handled in 1.12 by forge and some mods make it even worse.

I'm just testing a slightly optimized build, but there is no guarantee that it really helps. Outside this particular path, it is just vanilla/forge item rendering. Thus outside of our control.

yueh added a commit that referenced this issue Nov 30, 2017

@yueh yueh closed this in b70c865 Dec 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment