New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating Cable Anchors with Aluminum/Aluminium #3342

Closed
dash16 opened this Issue Jan 19, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@dash16

dash16 commented Jan 19, 2018

For some reason, the shapeless recipe to create Cable Anchors doesn't seem to be allowing use of Aluminum Ingots generated from CoFH World.

Description

All the Thermal Expansion Ores register as possible metal ingots to create cable anchors, except for Aluminum. I can only imagine this is because the config is looking for Aluminium.

cable_anchor.recipe
shapeless= metalIngots knife -> 3 ae2:part.CableAnchor

groups.recipe
group= mc:iron_ingot oredictionary:ingotCopper oredictionary:ingotTin oredictionary:ingotSilver oredictionary:ingotLead oredictionary:ingotBronze oredictionary:ingotBrass oredictionary:ingotNickel oredictionary:ingotInvar oredictionary:ingotAluminium -> metalIngots

I thought Forge's ore dictionary would have taken care of this, but ¯_(ツ)_/¯

Environment

  • CoFHCore-1.12.2-4.3.10.5

  • CoFHWorld-1.12.2-1.1.1.12

  • ThermalExpansion-1.12.2-5.3.10.15

  • ThermalFoundation-1.12.2-2.3.10.6

  • Minecraft Version: 1.12.2

  • AE2 Version: rv5-stable-5

  • Forge Version: 14.23.1.2590

@GuntherDW

This comment has been minimized.

Contributor

GuntherDW commented Mar 30, 2018

This part is handled by the JSON recipes.
The included .recipe files are deprecated and only a small subset is actually still being used while there is no other decent option for us at this moment to add machine recipes in the manner that we do.

It could be that the ingots aren't OD'ed as ingotAluminium but ingotAluminum? I'll take a quick look when I can.

EDIT: Yup, looks like it's looking for "ingotAluminum", not "ingotAluminium". Figures.
The quick fix would be to indeed add both to the JSON constants file.

@dash16

This comment has been minimized.

dash16 commented Apr 8, 2018

I'm not familiar with how I'd modify the JSON constants file, I'm only seeing .CFG files in my /config/AppliedEnergistics2 folder. Is this something I can fix on my end, or do I need to wait for a update to the mod?

@fscan

This comment has been minimized.

Member

fscan commented Jun 28, 2018

Imho, the correct solution would be that CoFH would register aluminium as both oredictionary:ingotAluminium and oredictionary:ingotAluminum. I'll see to fixing this on our end too.
In the meantime, you could add a recipe with CraftTweaker.

@leagris

This comment has been minimized.

leagris commented Jun 29, 2018

// Register Aluminum ingots as Aluminium
<ore:ingotAluminium>.addAll(<ore:ingotAluminum>);

@yueh yueh closed this in #3573 Jul 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment