Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Performance issue #3417

Closed
JoeSGT opened this issue Mar 7, 2018 · 3 comments
Closed

Possible Performance issue #3417

JoeSGT opened this issue Mar 7, 2018 · 3 comments

Comments

@JoeSGT
Copy link

@JoeSGT JoeSGT commented Mar 7, 2018

Description

Today i was using warmroast to figure out why my tps is going down and i had found this that may related to my issues, i highly believe it's AE2 that cause this issue anyways here is the picture
3b2924be7b12cac88be5db1496b79617

Environment

  • Minecraft Version: 1.12.2
  • AE2 Version: rv5-stable-9
  • Forge Version: 1.12.2-14.23.2.2624
@yueh
Copy link
Member

@yueh yueh commented Mar 7, 2018

This is ultimately about dealing with NBT heavy items, which is not the fastest option. As well as other mods adding caps to random items, which in some way is designed to be slow and allow other mods to make it even worse without much effort.

On a first look, there seems to be a way to compensate it to some degree. But the underlying issue will still be around everywhere we cannot compensate for it. That is just how Forge wants it to behave.

@yueh yueh added the enhancement label Mar 7, 2018
@yueh yueh added this to the rv5.stable - 1.12 milestone Mar 7, 2018
yueh added a commit that referenced this issue Mar 7, 2018
@JoeSGT
Copy link
Author

@JoeSGT JoeSGT commented Mar 8, 2018

Thanks you for a fast fix and quick reply <3

@yueh
Copy link
Member

@yueh yueh commented Mar 8, 2018

Still need to test some cases. The current implementation is still based on the earliest AE2 versions. So there might be or were some reason for the copy. E.g. to avoid issues with injecting more than 2B stacksize in a single operation. But there are no machines doing that and on first glance it would not even have prevent it.

@yueh yueh closed this in 59af05a Mar 8, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.