Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acc. card and export bus. #348

Closed
hisorange opened this issue Oct 25, 2014 · 13 comments
Closed

Acc. card and export bus. #348

hisorange opened this issue Oct 25, 2014 · 13 comments
Assignees
Labels

Comments

@hisorange
Copy link

@hisorange hisorange commented Oct 25, 2014

Aye the acceleration card's tooltip says 4 to import / export bus but the export only takes 3, with 4 it does nothing. ////// just a minor detail ///////

@Cisien
Copy link
Contributor

@Cisien Cisien commented Oct 26, 2014

The tool tip displays the amount that is allowed in the upgrade slots, not necessarily what is functional

@Cisien Cisien closed this Oct 26, 2014
@hisorange
Copy link
Author

@hisorange hisorange commented Oct 26, 2014

I see, but it can be easly missleading since the site does not document how many you can insert, and what I meant under 'it does nothing' was that it's stopping the export, so when one insert 4 card the export bus will not work anymore and since it's not mentioned anywhere just on the tooltip, either a line of explanation on the site or the tooltip could fix it.

@thatsIch thatsIch reopened this Oct 31, 2014
@thatsIch
Copy link
Member

@thatsIch thatsIch commented Oct 31, 2014

That it stops working is definitly a bug, cause it CAN use all 4 upgrade speeds (

    case 0:
        itemToSend = 1;
        break;
    case 1:
        itemToSend = 8;
        break;
    case 2:
        itemToSend = 32;
        break;
    case 3:
        itemToSend = 64;
        break;
    case 4:
        itemToSend = 96;
        break;
    }
@yueh
Copy link
Member

@yueh yueh commented Oct 31, 2014

There is a piece which sets it back to 64 if > 64. I have no idea why. Maybe some inventories have issues if extracting more than a single stack?

@thatsIch
Copy link
Member

@thatsIch thatsIch commented Oct 31, 2014

@yueh which part are you referring to?

@Cisien
Copy link
Contributor

@Cisien Cisien commented Oct 31, 2014

Is it failing because of ae or because of the target inventory?

Say we set it to max stack size for the item? The issue is still there, except there is no difference between 2 and 4 when moving say ender pearls into a dsu

@yueh
Copy link
Member

@yueh yueh commented Nov 1, 2014

Maybe it was another bus, but I am fairly sure that I remember seeing some code which sets the itemsToSend to min(64, itemToSend). It was also not directly adjacent to the switch itself.

@yueh
Copy link
Member

@yueh yueh commented Nov 12, 2014

Tested it in a creative world and an export bus with 3 upgrades will export 64 items each tick and 96 with 4.

The issue will be closed, until more information is provided on how to reproduce it.

@yueh yueh closed this Nov 12, 2014
@hisorange
Copy link
Author

@hisorange hisorange commented Nov 12, 2014

If you need a featured presentation how to reproduce the issue, just ask for it. Since I opened the issue there was not even a single comment like 'I can't reproduce it' so here is the setup.

http://i.imgur.com/OApDDeZ.png

Since I got a bit free time here is a deeper view, any other inventory can accept 96 pcs / export but DSU, maybe this is in fault, tested with barrels / chests / other intentories, seems to working.

@yueh
Copy link
Member

@yueh yueh commented Nov 12, 2014

Maybe but I am faintly remembering it is split up into 64 items per operation or something like that. So 96 would be a stack of 64 and a stack of 32.

@hisorange I do not really bother to ask for it explicitly, because we already do it when someone is opening an issue. It is mostly too tedious writing a first comment to the majority of issues about "read the guidelines".

@yueh yueh reopened this Nov 12, 2014
@yueh yueh added the bug label Nov 12, 2014
@Cisien
Copy link
Contributor

@Cisien Cisien commented Nov 12, 2014

I remember reproducing this with ender pearls into a dsu

@thatsIch
Copy link
Member

@thatsIch thatsIch commented Nov 14, 2014

mh with the DSU having 2 input slots, there should be no issue regarding that, probably needs further investigation

@yueh
Copy link
Member

@yueh yueh commented Nov 14, 2014

I have already investigated it.
The problem is that we want to push 96 items into the DSU, which it just does not accept and the export completely fails.

There is already some code in place which tries to split the export into smaller parts, but this is not really working.
I do not want to add more complexity to it, because this is already handled. We bascially just have to correctly use the max stack size supported by any inventory and return the leftover amount back for a next try. This should automatically split every push if 96 items into one with 64 and one with 32, of course in the same tick.

@yueh yueh closed this in cf89873 Dec 3, 2014
yueh added a commit that referenced this issue Dec 3, 2014
Fixes #348 by respecting the inventory stack limit
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.