Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default sort-by-mod order is reversed #3520

Closed
kylev opened this issue May 30, 2018 · 1 comment
Closed

Default sort-by-mod order is reversed #3520

kylev opened this issue May 30, 2018 · 1 comment
Labels
bug

Comments

@kylev
Copy link
Contributor

@kylev kylev commented May 30, 2018

Description: When using the crafting terminal, the default "Sort by" for "Mod" is reverse-alphabetical, contrasting with the default forward-alpha of "Item name". This is a confusing result, especially when the first item is from "rftools" because I don't have any mods installed that start in "z".

Repro:

  • Add a few additional mods of various names.
  • Create a fresh, minimal ME system with crafting terminal.
  • Add items from several mods to the system.
  • Note default "Item name" order puts "Apple" at the start of the list.
  • Click "Sort by" twice to switch to "By mod" sorting.

Expected:

  • Alphabetically early mods should sort first (like "appliedenergistics2" or "baubles").

Actual:

  • Later items like "minecraft" or "yoyos" are first.

  • Minecraft Version: 1.12.2

  • AE2 Version: DEV

  • Forge Version: forge-1.12.2-14.23.1.2554

@kylev
Copy link
Contributor Author

@kylev kylev commented May 30, 2018

Default sort By Item name
Default sort By Mod

@yueh yueh added the bug label Jun 1, 2018
yueh added a commit that referenced this issue Jun 2, 2018
…3517)

Comparable/Comparator implementation now use fast Java built-ins for
primitive types rather than hand-coded versions. Also DRY some code
and simplify logic.

This maintains the "biggest stack first" notion of "ascending", but
also fixes the inconsistent/accidental reversal of sort by mod (the
mod name should sort the same direction as the item name).
@yueh yueh closed this Jun 2, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.