Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize storage cells #3553

Closed
fscan opened this issue Jun 22, 2018 · 2 comments
Closed

Optimize storage cells #3553

fscan opened this issue Jun 22, 2018 · 2 comments

Comments

@fscan
Copy link
Member

@fscan fscan commented Jun 22, 2018

Currently, storage cells serialise to NBT on every inventory operation. Change the system to make serialisation the responsibility of the TE containing the cell so it can be better optimised.

Needs API changes.

@fscan fscan added the enhancement label Jun 22, 2018
@fscan fscan added this to the rv6.alpha - 1.12 milestone Jun 22, 2018
@yueh
Copy link
Member

@yueh yueh commented Jun 22, 2018

Most certainly will also require addons to potentially change any custom drive to behave differently and not fix some compile errors. E.g. They now need to take care of explicitly saving to disk on the cell being removed, the block destroyed etc. (Also applies to our own drives)

@fscan
Copy link
Member Author

@fscan fscan commented Jun 22, 2018

Sure .. i think for most TE's it makes sense to emulate the current behavior, eg: call saveChanges after every inject or extract.
The only real performance bottleneck are drives and maybe chests.

@fscan fscan closed this in #3586 Jul 14, 2018
fscan added a commit that referenced this issue Jul 14, 2018
API break!
Fixes #3553
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants