New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluid Level emitter not giving the correct signal with out filter #3821

Closed
myrddraall opened this Issue Nov 12, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@myrddraall
Copy link

myrddraall commented Nov 12, 2018

Fluid Level emitter not giving the correct signal with out filter

To Reproduce

All tests are with a simple network:
Energy source --> energy acceptor --> cable with emiiter + storage bus --> tank

  1. Set level emitter to greater than or equal 1 with no filter, then add fluid to the tank

    • no signal is emitted, this is contrary to how the item level emitter works (no filter means anything in the system)
  2. set filter to the fluid used and the emitter turns on (as expected)

  3. remove filter from emitter, emitter says on (as expected)
    4 remove fluid from tank

    • emitter stays on (bug)
    • same thing happens when the tank is removed vs the fluid removed

Expected behavior

When a Fluid level emitter doesn't have a filter set it should behave like it's item counterpart and count all fluid in the system

Additional context

Test setup:
https://ibb.co/k8j73V
config:
https://ibb.co/hMP4Hq

Environment

  • Minecraft Version: 1.12.2
  • AE2 Version: rv6-stable-4
  • Forge Version: 3770

@yueh yueh added this to the rv6.stable - 1.12 milestone Dec 24, 2018

yueh added a commit that referenced this issue Dec 24, 2018

@yueh yueh closed this in 05db930 Dec 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment