Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICraftingWatcherHost#onRequestChange() notified incorrectly #3832

Closed
yueh opened this issue Nov 24, 2018 · 0 comments
Closed

ICraftingWatcherHost#onRequestChange() notified incorrectly #3832

yueh opened this issue Nov 24, 2018 · 0 comments

Comments

@yueh
Copy link
Member

@yueh yueh commented Nov 24, 2018

Currently it is notified somewhat inconsistently on what it actually communicates.

The value passed to a listener is pretty ambiguous and can either mean it needs X more of the already requested amount or that it needs X replacing the previous request. Therefore most listener cannot depend on the value at all.

@yueh yueh added this to the rv6.stable - 1.12 milestone Nov 24, 2018
@yueh yueh self-assigned this Nov 24, 2018
yueh added a commit that referenced this issue Nov 24, 2018
yueh added a commit that referenced this issue Dec 23, 2018
@yueh yueh closed this Dec 23, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant