Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dense smart cables render incorrectly (junctions should not be there) #4089

Closed
hubertnnn opened this issue Jul 7, 2019 · 1 comment
Closed

Dense smart cables render incorrectly (junctions should not be there) #4089

hubertnnn opened this issue Jul 7, 2019 · 1 comment
Labels

Comments

@hubertnnn
Copy link

@hubertnnn hubertnnn commented Jul 7, 2019

Dense smart cables render as a junction in a few situations that they should not.

Describe the bug
dense_smart

As shown on the image above, I have 3 strait lines using a mix of covered dense and smart dense cables.
In all 3 cases there are no cables behind, just the strait line.
Order of cables in each line:

  1. covered, smart, smart, covered
  2. covered, smart, covered, controller
  3. covered, covered, smart, controller

Only second case renders correctly,
If a smart cable touches another smart cable it renders as junction.
If a smart cable touches controller it renders as junction.

Expected behavior
All 3 cases should render without junctions.

Environment

  • Minecraft Version: 1.12.2 SP
  • AE2 Version: rv6-stable-6
  • Forge Version: 14.23.5.2838
  • Modpack: Omnifactory 1.2.1 with channels enabled as only config change
@yueh
Copy link
Member

@yueh yueh commented Jul 23, 2019

The actual bug is rendering a smart connection towards the dense covered cable, this should be a covered one. As well as rendering the dense smart between two covered ones as cable core.

We did change the cable rendering to always render a core when changing the type with downgrading the connection between both to the lower one. E.g. connection between a smart cable and covered cable will be rendered as completely covered and not one half smart and the other one covered.

@yueh yueh closed this in c483bd1 Jul 23, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants