Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immibis' Microblocks integration causes bugs in Immibis' Microblocks #666

Closed
asiekierka opened this issue Dec 31, 2014 · 2 comments
Closed

Immibis' Microblocks integration causes bugs in Immibis' Microblocks #666

asiekierka opened this issue Dec 31, 2014 · 2 comments
Assignees
Milestone

Comments

@asiekierka
Copy link

@asiekierka asiekierka commented Dec 31, 2014

After sitting with @immibis for a while, we found that this issue: http://asie.pl/microblocks.mp4 - is reproducible in singleplayer with just AE2 and Immibis' Microblocks present.

What seems to be happening, from my initial glance at the code, is that AE2 overrides the part placement code with its own for non-AE2 tiles (that is, any tile entity), which causes synchronization bugs as it's not how you're supposed to be doing things.

...also, I got the worst possible issue number.

@immibis
Copy link

@immibis immibis commented Dec 31, 2014

if ( host == null && tile != null && AppEng.instance.isIntegrationEnabled( IntegrationType.ImmibisMicroblocks ) )
may be relevant - it appears (though I haven't tried it in a debugger) to convert Immibis's Microblocks container blocks into AE2 part container blocks, if you right-click any Immibis's Microblocks container block, on the client only.

I suspect the AE2 container block then deletes itself since it doesn't contain any AE2 parts, but I haven't delved into that code yet.

Again, everything in this comment has not been verified.

@yueh
Copy link
Member

@yueh yueh commented Dec 31, 2014

Debugging it would probably be very helpful.
Interestingly I get L250 reported as dead code. But I have never validated it as false-positive, because it is not high on my list.

yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Dec 31, 2014
@thatsIch thatsIch added the type-bug label Dec 31, 2014
@thatsIch thatsIch added this to the rv2 milestone Dec 31, 2014
yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Dec 31, 2014
yueh added a commit to yueh/Applied-Energistics-2 that referenced this issue Dec 31, 2014
@yueh yueh closed this in ff903e6 Jan 1, 2015
yueh added a commit that referenced this issue Jan 1, 2015
Fixes #666 Only convert to a cablebus if an IPartItem is attached
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.