Buildcraft integration crash #743

Closed
floridaman opened this Issue Jan 18, 2015 · 10 comments

Comments

Projects
None yet
4 participants
@floridaman

Server crashes whenever I place a BC pipe next to a storage bus. I either have to disable BC integration or delete the pipe using an editor to get it to boot again. Here is the crash log.

http://paste.ee/p/Nh4Y4

I am using:
Buildcraft 6.3.1
AE2 RV2-BETA-7

@yueh

This comment has been minimized.

Show comment
Hide comment
@yueh

yueh Jan 18, 2015

Member

It looks like BC has changed something with the pipe plugs according to the crashlog.
I will look into it later.

Member

yueh commented Jan 18, 2015

It looks like BC has changed something with the pipe plugs according to the crashlog.
I will look into it later.

@yueh

This comment has been minimized.

Show comment
Hide comment
@yueh

yueh Jan 18, 2015

Member

It looks like BuildCraft broke some APIs (or better moved it to the API instead of internal classes).
So I am currently not sure if we can support 6.3.x as well as earlier version parallel.

@asiekierka I remember @thatsIch having some questions about something related to Facades and some crashes. Could you both solve it?

Member

yueh commented Jan 18, 2015

It looks like BuildCraft broke some APIs (or better moved it to the API instead of internal classes).
So I am currently not sure if we can support 6.3.x as well as earlier version parallel.

@asiekierka I remember @thatsIch having some questions about something related to Facades and some crashes. Could you both solve it?

@thatsIch

This comment has been minimized.

Show comment
Hide comment
@thatsIch

thatsIch Mar 9, 2015

Member

I am still waiting for a response for that, but I guess, we just remove it for now

Member

thatsIch commented Mar 9, 2015

I am still waiting for a response for that, but I guess, we just remove it for now

@yueh

This comment has been minimized.

Show comment
Hide comment
@yueh

yueh Mar 9, 2015

Member

Removing a feature is not really ideal, but you can currently force a crash with AE2 and newer buildcraft versions, as the API changed quite heavily.

So removing it and moving on is probably the best option for now.

Member

yueh commented Mar 9, 2015

Removing a feature is not really ideal, but you can currently force a crash with AE2 and newer buildcraft versions, as the API changed quite heavily.

So removing it and moving on is probably the best option for now.

@asiekierka

This comment has been minimized.

Show comment
Hide comment
@asiekierka

asiekierka Mar 9, 2015

Always support the latest stable release and that only. If you plan to support 6.3.x+ only, remove MJ integration altogether.

If you need any help from me to keep supporting BC, please tell me! It is very important to me that mods keep supporting BuildCraft.

Always support the latest stable release and that only. If you plan to support 6.3.x+ only, remove MJ integration altogether.

If you need any help from me to keep supporting BC, please tell me! It is very important to me that mods keep supporting BuildCraft.

@yueh

This comment has been minimized.

Show comment
Hide comment
@yueh

yueh Mar 9, 2015

Member

I do not see anything preventing the BuildCraft support (as long as we are able).

It is mostly about the jump between 6.2 and 6.3 (or was it 6.1->6.2?) is pretty large.
And the lack of time on my side (and probably @thatsIch).
I also vaguely remember 6.3 not even providing the necessary functions for our integration, but as far as I know, they were added later in 6.3 or 6.4. (Detecting a plugged pipe in an easy way)

Member

yueh commented Mar 9, 2015

I do not see anything preventing the BuildCraft support (as long as we are able).

It is mostly about the jump between 6.2 and 6.3 (or was it 6.1->6.2?) is pretty large.
And the lack of time on my side (and probably @thatsIch).
I also vaguely remember 6.3 not even providing the necessary functions for our integration, but as far as I know, they were added later in 6.3 or 6.4. (Detecting a plugged pipe in an easy way)

@thatsIch

This comment has been minimized.

Show comment
Hide comment
@thatsIch

thatsIch Mar 9, 2015

Member

As stated in here,
the BC API lacks an entry point to create an actual Facade when we wrench them from our cables. Currently I am using the internal class ItemFacade to get the ItemStack, or I am missing the pointer to where I get access to that class via the API

Member

thatsIch commented Mar 9, 2015

As stated in here,
the BC API lacks an entry point to create an actual Facade when we wrench them from our cables. Currently I am using the internal class ItemFacade to get the ItemStack, or I am missing the pointer to where I get access to that class via the API

@thatsIch

This comment has been minimized.

Show comment
Hide comment
@thatsIch

thatsIch Mar 9, 2015

Member

nvm I think I figured it out. Facades fixed indev

Member

thatsIch commented Mar 9, 2015

nvm I think I figured it out. Facades fixed indev

@asiekierka

This comment has been minimized.

Show comment
Hide comment
@asiekierka

asiekierka Mar 9, 2015

@thatslch - you can just store a copy of the ItemStack which is an IFacadeItem. (This would automatically add support for any ItemStack implementing IFacadeItem, which would be an interesting bonus.)

@thatslch - you can just store a copy of the ItemStack which is an IFacadeItem. (This would automatically add support for any ItemStack implementing IFacadeItem, which would be an interesting bonus.)

@thatsIch

This comment has been minimized.

Show comment
Hide comment
@thatsIch

thatsIch Mar 9, 2015

Member

Actually its about, when the network is being constructed, forget the wrenching.

At that point of time, we only know the type of block, the meta and if its of BC or not. ItemFacade.FacadeState.create was perfect for that.

Member

thatsIch commented Mar 9, 2015

Actually its about, when the network is being constructed, forget the wrenching.

At that point of time, we only know the type of block, the meta and if its of BC or not. ItemFacade.FacadeState.create was perfect for that.

@thatsIch thatsIch added the state-fixed label Mar 9, 2015

@thatsIch thatsIch self-assigned this Mar 9, 2015

@thatsIch thatsIch added this to the rv2 milestone Mar 9, 2015

@thatsIch thatsIch closed this in e300bf9 Mar 10, 2015

thatsIch added a commit that referenced this issue Mar 10, 2015

Merge pull request #992 from thatsIch/e-319-new-bc
Fixes #743 crash with plugs, fixes #942 builder integration, closes #319 BC 6 prep
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment