New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some GUIs don't respect extended reach #920

Closed
RAnders00 opened this Issue Feb 20, 2015 · 6 comments

Comments

Projects
None yet
5 participants
@RAnders00

RAnders00 commented Feb 20, 2015

As you can see here, the ME Drive (just as a example) does not respect extended reach (like the botania ring does)

I tested it using the latest AE2 and latest forge in singleplayer. (AE RV2-Beta-8, Forge #1291, Botania r1.5-163) as visible in the video. Also no other mods and via vanilla launcher.

@Cisien

This comment has been minimized.

Show comment
Hide comment
@Cisien

Cisien Feb 20, 2015

Contributor

The AE GUIs explicitly check to make sure the player is within range, so this is by design.

Contributor

Cisien commented Feb 20, 2015

The AE GUIs explicitly check to make sure the player is within range, so this is by design.

@RAnders00

This comment has been minimized.

Show comment
Hide comment
@RAnders00

RAnders00 Feb 21, 2015

But I am in range! The range is just not the vanilla range, but it's modified. Did you even watch the video and have you read the text? Wow. I know that they close when you are out of range, but the range that they check for is not respecting range extenders.

RAnders00 commented Feb 21, 2015

But I am in range! The range is just not the vanilla range, but it's modified. Did you even watch the video and have you read the text? Wow. I know that they close when you are out of range, but the range that they check for is not respecting range extenders.

@yueh

This comment has been minimized.

Show comment
Hide comment
@yueh

yueh Feb 22, 2015

Member

And there is a reliable way to distinguish between a somewhat valid range extender like the botania ring and something just temporary extending it to circumvent it?

Member

yueh commented Feb 22, 2015

And there is a reliable way to distinguish between a somewhat valid range extender like the botania ring and something just temporary extending it to circumvent it?

@Cisien

This comment has been minimized.

Show comment
Hide comment
@Cisien

Cisien Feb 22, 2015

Contributor

My point was the only known valid range is vanilla. There are no callbacks in vanilla that can tell us if the player is in range or not. Because of this, it is hard coded. It is hard coded like this to block mods that extend the range (such as enderio)

Contributor

Cisien commented Feb 22, 2015

My point was the only known valid range is vanilla. There are no callbacks in vanilla that can tell us if the player is in range or not. Because of this, it is hard coded. It is hard coded like this to block mods that extend the range (such as enderio)

@AlgorithmX2

This comment has been minimized.

Show comment
Hide comment
@AlgorithmX2

AlgorithmX2 Feb 24, 2015

Contributor

@Cisien random thought, has anyone looked at TileChest.isUseableByPlayer to see if maybe something changed in a newer build of forge/MC? The isUseableByPlayer for AE2 is probably based on 1.6, so its possible there have been changes made.

I can't check since I don't have any source.

if its still hard coded then there is not much we can do, if it uses some new method to get the player reach, we can swap it out.

Contributor

AlgorithmX2 commented Feb 24, 2015

@Cisien random thought, has anyone looked at TileChest.isUseableByPlayer to see if maybe something changed in a newer build of forge/MC? The isUseableByPlayer for AE2 is probably based on 1.6, so its possible there have been changes made.

I can't check since I don't have any source.

if its still hard coded then there is not much we can do, if it uses some new method to get the player reach, we can swap it out.

@thatsIch

This comment has been minimized.

Show comment
Hide comment
@thatsIch

thatsIch Mar 10, 2015

Member

Looking through the code of minecraft, I found nothing we can swap it out. What we can do is just increase it to the default range of Minecraft which is the root of 64 (currently we are at the root of 32)

Member

thatsIch commented Mar 10, 2015

Looking through the code of minecraft, I found nothing we can swap it out. What we can do is just increase it to the default range of Minecraft which is the root of 64 (currently we are at the root of 32)

@thatsIch thatsIch closed this in c9f0b4e Mar 11, 2015

thatsIch added a commit that referenced this issue Mar 11, 2015

Merge pull request #998 from thatsIch/e-920-extended-reach
Fixes #920 Increased GUI close distance to Vanilla MC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment