New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire ExplosionEvent for Tiny TNT #932

Closed
MineMaarten opened this Issue Feb 23, 2015 · 6 comments

Comments

Projects
None yet
6 participants
@MineMaarten

MineMaarten commented Feb 23, 2015

Some people have reported to me that Tiny TNT can't be used anymore to get Compressed Iron from Iron in PneumaticCraft. Recently, as a refactor, I've instead of using custom EntityItems, hooked into forge's ExplosionEvent to spawn Compressed Iron. This works fine for normal explosions.

After investigation, it seems that Tiny TNT simulates Explosions in a custom way, and doesn't fire the ExplosionEvent. My suggestion would be to do this :). Or, a simpler solution is to use World#createExplosion instead. But, I assume there was a reason to not do that in the first place?

@yueh

This comment has been minimized.

Show comment
Hide comment
@yueh

yueh Feb 23, 2015

Member

´World.createExplosion()´ is not really an option. There is no guarantee that any explosion will happen as the explosion damage can be disabled in the configuration.

An ExplosionEvent is likely the way to go, but not available with the forge version we are currently using.

Member

yueh commented Feb 23, 2015

´World.createExplosion()´ is not really an option. There is no guarantee that any explosion will happen as the explosion damage can be disabled in the configuration.

An ExplosionEvent is likely the way to go, but not available with the forge version we are currently using.

@Cisien

This comment has been minimized.

Show comment
Hide comment
@Cisien

Cisien Feb 23, 2015

Contributor

I seem to remember algo going this route because of mods or addond for bukkit that blocked explosions. This would allow players to still be able to craft singularities even when the explosions are disabled

Contributor

Cisien commented Feb 23, 2015

I seem to remember algo going this route because of mods or addond for bukkit that blocked explosions. This would allow players to still be able to craft singularities even when the explosions are disabled

@AlgorithmX2

This comment has been minimized.

Show comment
Hide comment
@AlgorithmX2

AlgorithmX2 Feb 24, 2015

Contributor

Might need to either update forge, or reflect the event ; its likely the only solution without damaging the anti-explosion behavior.

Contributor

AlgorithmX2 commented Feb 24, 2015

Might need to either update forge, or reflect the event ; its likely the only solution without damaging the anti-explosion behavior.

@yueh

This comment has been minimized.

Show comment
Hide comment
@yueh

yueh Feb 24, 2015

Member

I am already planning on updating forge to the latest recommended version as well as stuff like NEI. (It is probably WAILA breaking NEI 1.0.3 for indev).
Just have not come around to do it.

Adding the event is pretty trivial after that.

Member

yueh commented Feb 24, 2015

I am already planning on updating forge to the latest recommended version as well as stuff like NEI. (It is probably WAILA breaking NEI 1.0.3 for indev).
Just have not come around to do it.

Adding the event is pretty trivial after that.

@JasonMcRay

This comment has been minimized.

Show comment
Hide comment
@JasonMcRay

JasonMcRay Mar 5, 2016

Sorry to bump this. but is something being done with this? It has been a year since the report and it still doesnt seem to be implemented.

JasonMcRay commented Mar 5, 2016

Sorry to bump this. but is something being done with this? It has been a year since the report and it still doesnt seem to be implemented.

@thatsIch

This comment has been minimized.

Show comment
Hide comment
@thatsIch

thatsIch Apr 27, 2016

Member

sorry, not of importance

Member

thatsIch commented Apr 27, 2016

sorry, not of importance

yueh added a commit that referenced this issue Nov 15, 2017

Fixes #932: Fire ExplosionEvent.Detonate when tiny TNT explodes.
This still bypasses the start event to prevent it from ever being
cancelled.

@yueh yueh closed this in 33754d2 Nov 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment