/Applied-Energistics-2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes default RF tooltip on WAILA 1.5.9+ #1468

Merged
merged 1 commit into from May 18, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
  rv3 - 1.7.10
3 participants
@TheJulianJES @thatsIch @yueh
@TheJulianJES
Contributor

TheJulianJES commented May 16, 2015

Was talked about on IRC.
Can also do this to rv2 but I don't think this is really needed.
@thatsIch

This comment has been minimized.

Show comment
Hide comment
@thatsIch

thatsIch May 16, 2015

Member

the indention looks a bit strange to me
Member

thatsIch commented May 16, 2015

the indention looks a bit strange to me
@TheJulianJES

This comment has been minimized.

Show comment
Hide comment
@TheJulianJES

TheJulianJES May 16, 2015

Contributor

@thatsIch It is working for me...
Contributor

TheJulianJES commented May 16, 2015

@thatsIch It is working for me...
@yueh

This comment has been minimized.

Show comment
Hide comment
@yueh

yueh May 16, 2015

Member

Is it guaranteed to be an ITaggedList or can it potentially throw a ClassCastException?
Member

yueh commented May 16, 2015

Is it guaranteed to be an ITaggedList or can it potentially throw a ClassCastException?
@TheJulianJES

This comment has been minimized.

Show comment
Hide comment
@TheJulianJES

TheJulianJES May 16, 2015

Contributor

Yep, I don't think it can throw a ClassCastException.
It is always a ITaggedList
Contributor

TheJulianJES commented May 16, 2015

Yep, I don't think it can throw a ClassCastException.
It is always a ITaggedList
@thatsIch

This comment has been minimized.

Show comment
Hide comment
@thatsIch

thatsIch May 17, 2015

Member

It looks to me, that the block after the removal is indented one tab further
Member

thatsIch commented May 17, 2015

It looks to me, that the block after the removal is indented one tab further
@TheJulianJES

This comment has been minimized.

Show comment
Hide comment
@TheJulianJES

TheJulianJES May 17, 2015

Contributor

No? @thatsIch
Will post some screenshots later
Contributor

TheJulianJES commented May 17, 2015

No? @thatsIch
Will post some screenshots later
@yueh

This comment has been minimized.

Show comment
Hide comment
@yueh

yueh May 17, 2015

Member

I see spaces and a bunch of trailing whitespaces.
Member

yueh commented May 17, 2015

I see spaces and a bunch of trailing whitespaces.
@TheJulianJES

This comment has been minimized.

Show comment
Hide comment
@TheJulianJES

TheJulianJES May 17, 2015

Contributor

@yueh Will search and then do :)
Contributor

TheJulianJES commented May 17, 2015

@yueh Will search and then do :)
@TheJulianJES

This comment has been minimized.

Show comment
Hide comment
@TheJulianJES

TheJulianJES May 17, 2015

Contributor

Without RF: http://gyazo.com/f9e5c41c461cf94a6a9df1103aef3879
With RF: http://gyazo.com/c97bf05ad2311794fa4366a33c09ffe1
Contributor

TheJulianJES commented May 17, 2015

Without RF: http://gyazo.com/f9e5c41c461cf94a6a9df1103aef3879
With RF: http://gyazo.com/c97bf05ad2311794fa4366a33c09ffe1
@TheJulianJES
Removes default RF tooltip 
Removed tab

Did something
0bfb7b7
@TheJulianJES

This comment has been minimized.

Show comment
Hide comment
@TheJulianJES

TheJulianJES May 17, 2015

Contributor

@yueh All fixed, I think :)
Contributor

TheJulianJES commented May 17, 2015

@yueh All fixed, I think :)
@thatsIch

This comment has been minimized.

Show comment
Hide comment
@thatsIch

thatsIch May 17, 2015

Member

it looked like this before the commit
Member

thatsIch commented May 17, 2015

it looked like this before the commit
@TheJulianJES

This comment has been minimized.

Show comment
Hide comment
@TheJulianJES

TheJulianJES May 17, 2015

Contributor

#BlameEclipse
Contributor

TheJulianJES commented May 17, 2015

#BlameEclipse

@yueh yueh added the review-accepted label May 18, 2015

thatsIch added a commit that referenced this pull request May 18, 2015

@thatsIch
Merge pull request #1468 from TheJulianJES/noRFtooltip 
Removes default RF tooltip on WAILA 1.5.9+
962c7c0

@thatsIch thatsIch merged commit 962c7c0 into AppliedEnergistics:master May 18, 2015
1 check passed

1 check passed

default Finished TeamCity Build Applied Energistics :: Pull Requests : Tests passed: 51
Details

@yueh yueh added this to the rv3 - 1.7.10 milestone Aug 8, 2015

@yueh yueh added version-rv2 labels Aug 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment