Skip to content

/ Applied-Energistics-2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes default RF tooltip on WAILA 1.5.9+ #1468

Merged
merged 1 commit into from May 18, 2015
Merged

Removes default RF tooltip on WAILA 1.5.9+ #1468

merged 1 commit into from May 18, 2015

Conversation

@TheJulianJES
Copy link
Contributor

@TheJulianJES TheJulianJES commented May 16, 2015

Was talked about on IRC.
Can also do this to rv2 but I don't think this is really needed.
@thatsIch
Copy link
Member

@thatsIch thatsIch commented May 16, 2015

the indention looks a bit strange to me
@TheJulianJES
Copy link
Contributor Author

@TheJulianJES TheJulianJES commented May 16, 2015

@thatsIch It is working for me...
@yueh
Copy link
Member

@yueh yueh commented May 16, 2015

Is it guaranteed to be an ITaggedList or can it potentially throw a ClassCastException?
@TheJulianJES
Copy link
Contributor Author

@TheJulianJES TheJulianJES commented May 16, 2015

Yep, I don't think it can throw a ClassCastException.
It is always a ITaggedList
@thatsIch
Copy link
Member

@thatsIch thatsIch commented May 17, 2015

It looks to me, that the block after the removal is indented one tab further
@TheJulianJES
Copy link
Contributor Author

@TheJulianJES TheJulianJES commented May 17, 2015

No? @thatsIch
Will post some screenshots later
@yueh
Copy link
Member

@yueh yueh commented May 17, 2015

I see spaces and a bunch of trailing whitespaces.
@TheJulianJES
Copy link
Contributor Author

@TheJulianJES TheJulianJES commented May 17, 2015

@yueh Will search and then do :)
@TheJulianJES
Copy link
Contributor Author

@TheJulianJES TheJulianJES commented May 17, 2015

Without RF: http://gyazo.com/f9e5c41c461cf94a6a9df1103aef3879
With RF: http://gyazo.com/c97bf05ad2311794fa4366a33c09ffe1
@TheJulianJES TheJulianJES force-pushed the TheJulianJES:noRFtooltip branch from 6191237 to 356c84a May 17, 2015
@TheJulianJES
Removes default RF tooltip
Loading status checks…
0bfb7b7 
Removed tab

Did something
@TheJulianJES TheJulianJES force-pushed the TheJulianJES:noRFtooltip branch from 356c84a to 0bfb7b7 May 17, 2015
@TheJulianJES
Copy link
Contributor Author

@TheJulianJES TheJulianJES commented May 17, 2015

@yueh All fixed, I think :)
@thatsIch
Copy link
Member

@thatsIch thatsIch commented May 17, 2015

it looked like this before the commit
@TheJulianJES
Copy link
Contributor Author

@TheJulianJES TheJulianJES commented May 17, 2015

#BlameEclipse
thatsIch added a commit that referenced this pull request May 18, 2015
@thatsIch
Merge pull request #1468 from TheJulianJES/noRFtooltip
Loading status checks…
962c7c0 
Removes default RF tooltip on WAILA 1.5.9+
@thatsIch thatsIch merged commit 962c7c0 into AppliedEnergistics:master May 18, 2015
1 check passed
1 check passed
default Finished TeamCity Build Applied Energistics :: Pull Requests : Tests passed: 51
Details
@yueh yueh added this to the rv3 - 1.7.10 milestone Aug 8, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
rv3 - 1.7.10
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@TheJulianJES @thatsIch @yueh