Fixes #1786: Locale critical code now uses the english local. Fixes Turkish Problem. #1787

Merged
merged 1 commit into from Aug 15, 2015

Conversation

Projects
None yet
2 participants
@thatsIch
Member

thatsIch commented Aug 10, 2015

Applied English Locale where localization is not expected as in internal recipe handling and IMC handling, basically which interacts with public API where we either require to enforce the incoming text with regex ([a-z0-9]) or just expect proper usage of the API, but with just using upper cases in recipe files it would break in Turkish Locale like

ALIAS

another option would have been to use equalsIgnoreCase in some cases, but not all applicable

Fixes #1786: Locale critical code now uses the english local for tra…
…nsmission. Fixes Turkish Problem.

Applied English Locale where localization is not expected as in internal recipe handling and IMC handling, basically which interacts with public API where we either require to enforce the incoming text with regex ([a-z0-9]) or just expect proper usage of the API, but with just using upper cases in recipe files it would break in Turkish Locale like

ALIAS

another option would have been to use `equalsIgnoreCase` in some cases, but not all applicable
@yueh

This comment has been minimized.

Show comment
Hide comment
@yueh

yueh Aug 10, 2015

Member

The reddit post also suggest using Locale.ROOT to have a neutral Locale and not have to deal with potential cases specific to english.

Member

yueh commented Aug 10, 2015

The reddit post also suggest using Locale.ROOT to have a neutral Locale and not have to deal with potential cases specific to english.

@thatsIch

This comment has been minimized.

Show comment
Hide comment
@thatsIch

thatsIch Aug 10, 2015

Member

This is to not use LOCALE.US which is just US, not normal English locale, but we are def using English in the API

Member

thatsIch commented Aug 10, 2015

This is to not use LOCALE.US which is just US, not normal English locale, but we are def using English in the API

yueh added a commit that referenced this pull request Aug 15, 2015

Merge pull request #1787 from thatsIch/b-1786-turkish-locale
Fixes #1786: Locale critical code now uses the english local. Fixes Turkish Problem.

@yueh yueh merged commit c3db5ef into AppliedEnergistics:master Aug 15, 2015

2 checks passed

default Finished TeamCity Build Applied Energistics :: Pull Requests : Tests passed: 53
Details
jenkins Success 53 tests run, 0 skipped, 0 failed.
Details

@thatsIch thatsIch deleted the thatsIch:b-1786-turkish-locale branch Aug 20, 2015

@yueh yueh added this to the rv3 - 1.7.10 milestone Dec 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment