Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1786: Locale critical code now uses the english local. Fixes Turkish Problem. #1787

Merged
merged 1 commit into from Aug 15, 2015
Merged

Fixes #1786: Locale critical code now uses the english local. Fixes Turkish Problem. #1787

merged 1 commit into from Aug 15, 2015

Conversation

@thatsIch
Copy link
Member

@thatsIch thatsIch commented Aug 10, 2015

Applied English Locale where localization is not expected as in internal recipe handling and IMC handling, basically which interacts with public API where we either require to enforce the incoming text with regex ([a-z0-9]) or just expect proper usage of the API, but with just using upper cases in recipe files it would break in Turkish Locale like

ALIAS

another option would have been to use equalsIgnoreCase in some cases, but not all applicable

…smission. Fixes Turkish Problem.

Applied English Locale where localization is not expected as in internal recipe handling and IMC handling, basically which interacts with public API where we either require to enforce the incoming text with regex ([a-z0-9]) or just expect proper usage of the API, but with just using upper cases in recipe files it would break in Turkish Locale like

ALIAS

another option would have been to use `equalsIgnoreCase` in some cases, but not all applicable
@yueh
Copy link
Member

@yueh yueh commented Aug 10, 2015

The reddit post also suggest using Locale.ROOT to have a neutral Locale and not have to deal with potential cases specific to english.

@thatsIch
Copy link
Member Author

@thatsIch thatsIch commented Aug 10, 2015

This is to not use LOCALE.US which is just US, not normal English locale, but we are def using English in the API

yueh added a commit that referenced this pull request Aug 15, 2015
Fixes #1786: Locale critical code now uses the english local. Fixes Turkish Problem.
@yueh yueh merged commit c3db5ef into AppliedEnergistics:master Aug 15, 2015
2 checks passed
2 checks passed
@FireBall1725
default Finished TeamCity Build Applied Energistics :: Pull Requests : Tests passed: 53
Details
@yueh
jenkins Success 53 tests run, 0 skipped, 0 failed.
Details
@thatsIch thatsIch deleted the thatsIch:b-1786-turkish-locale branch Aug 20, 2015
@yueh yueh added this to the rv3 - 1.7.10 milestone Dec 9, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants