New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganizes the recipes in a more reasonable way. #1805

Merged
merged 1 commit into from Aug 22, 2015

Conversation

Projects
None yet
2 participants
@yueh
Member

yueh commented Aug 15, 2015

The recipes are now structured into multipe subfolder and split into more
distinct files, so the names are more appropriate and are better at
hinting which items the actually contain.

It also extends the RecipeResourceCopier to now handle the folder
recursively and extract all subdirectories and their files.

"import=" is currently requiring a relative path to the root directory
of the recipes. This would require a larger rewrite/refactoring, thus it
is kept for now until a potentially later changer.

This reverts splitting the oredict entries into their own directory and
moves them back into the recipes folder, as it currently is causing a
couple of issues like not being able to resolve the aliases or is not
working indev. But to keep it seperate it is now its own recipe file.

Fixes #1791
Reverts #1635

@yueh yueh added this to the rv3 - 1.7.10 milestone Aug 15, 2015

@thatsIch

This comment has been minimized.

Show comment
Hide comment
@thatsIch

thatsIch Aug 20, 2015

Member
  • misc.recipe in misc folder is somewhat badly named
  • cables/misc.recipe maybe into parts?
Member

thatsIch commented Aug 20, 2015

  • misc.recipe in misc folder is somewhat badly named
  • cables/misc.recipe maybe into parts?

@thatsIch thatsIch self-assigned this Aug 20, 2015

@yueh

This comment has been minimized.

Show comment
Hide comment
@yueh

yueh Aug 20, 2015

Member

I am not really happy with misc in general. It is really the place for leftover/uncategorized stuff.

I was thinking about mirroring the API with blocks/parts/materials/etc. But this is also not really fitting.

Member

yueh commented Aug 20, 2015

I am not really happy with misc in general. It is really the place for leftover/uncategorized stuff.

I was thinking about mirroring the API with blocks/parts/materials/etc. But this is also not really fitting.

@thatsIch

This comment has been minimized.

Show comment
Hide comment
@thatsIch

thatsIch Aug 20, 2015

Member

the general layout looks fine to me,

  • misc.recipe is just containing TNT so maybe just use it
  • cables/misc.recipes are anchors and such, which are technically no cables
Member

thatsIch commented Aug 20, 2015

the general layout looks fine to me,

  • misc.recipe is just containing TNT so maybe just use it
  • cables/misc.recipes are anchors and such, which are technically no cables
Reorganizes the recipes in a more reasonable way.
The recipes are now structured into multipe subfolder and split into more
distinct files, so the names are more appropriate and are better at
hinting which items the actually contain.

It also extends the RecipeResourceCopier to now handle the folder
recursively and extract all subdirectories and their files.

"import=" is currently requiring a relative path to the root directory
of the recipes. This would require a larger rewrite/refactoring, thus it
is kept for now until a potentially later changer.

This reverts splitting the oredict entries into their own directory and
moves them back into the recipes folder, as it currently is causing a
couple of issues like not being able to resolve the aliases or is not
working indev. But to keep it seperate it is now its own recipe file.

Fixes #1791
Reverts #1635
@yueh

This comment has been minimized.

Show comment
Hide comment
@yueh

yueh Aug 21, 2015

Member

Small update to the build.gradle to no longer include the unused oredict folder.

Member

yueh commented Aug 21, 2015

Small update to the build.gradle to no longer include the unused oredict folder.

@thatsIch

This comment has been minimized.

Show comment
Hide comment
@thatsIch

thatsIch Aug 21, 2015

Member

makes sense

Member

thatsIch commented Aug 21, 2015

makes sense

yueh added a commit that referenced this pull request Aug 22, 2015

Merge pull request #1805 from yueh/feature-recipes-refactoring
Reorganizes the recipes in a more reasonable way.

@yueh yueh merged commit 26daaf2 into AppliedEnergistics:master Aug 22, 2015

2 checks passed

default Finished TeamCity Build Applied Energistics :: Pull Requests : Tests passed: 53
Details
jenkins Success 53 tests run, 0 skipped, 0 failed.
Details
@thatsIch

This comment has been minimized.

Show comment
Hide comment
@thatsIch

thatsIch Aug 24, 2015

Member

I noticed that some recipes were not working looking at the console

Member

thatsIch commented Aug 24, 2015

I noticed that some recipes were not working looking at the console

@yueh

This comment has been minimized.

Show comment
Hide comment
@yueh

yueh Aug 24, 2015

Member

Any specific ones? I went through all items ingame (hopefully not missed any) and there were no issues.

Also do not forget, that even before some recipes did fail to resolve in indev, as for example the wooden gear is disabled as BC already provides one. If I remember correclty, it were always 2 or 3 recipes failing due to having some other mods indev.

Member

yueh commented Aug 24, 2015

Any specific ones? I went through all items ingame (hopefully not missed any) and there were no issues.

Also do not forget, that even before some recipes did fail to resolve in indev, as for example the wooden gear is disabled as BC already provides one. If I remember correclty, it were always 2 or 3 recipes failing due to having some other mods indev.

@thatsIch

This comment has been minimized.

Show comment
Hide comment
@thatsIch

thatsIch Aug 31, 2015

Member

oh right.. need better messages

but some did contain typos I think thus failing to resolve.

Member

thatsIch commented Aug 31, 2015

oh right.. need better messages

but some did contain typos I think thus failing to resolve.

@thatsIch

This comment has been minimized.

Show comment
Hide comment
@thatsIch

thatsIch Aug 31, 2015

Member

posted in IRC

Member

thatsIch commented Aug 31, 2015

posted in IRC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment