New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layers and IC2 Tunnel #2565
Layers and IC2 Tunnel #2565
Conversation
…y -1 was returned, causing the ENet to ignore the P2P output side. Sadly, the tier cannot be changed once the tile is registered, so we're going with the highest there is. The effect of this is not quite clear at this point... kaboom?
@@ -28,7 +28,6 @@ | |||
import java.util.Map; | |||
import java.util.Map.Entry; | |||
import java.util.Set; | |||
|
|||
import javax.annotation.Nonnull; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return cache.getUnchecked( new CacheKey( baseClass, this.desc ) ); | ||
} | ||
|
||
private Class<? extends AEBaseTile> generateCombinedClass( CacheKey cacheKey ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -222,8 +225,15 @@ String getUnlocalizedName() | |||
} | |||
}, | |||
|
|||
// P2PTunnelEU( 465, EnumSet.of( AEFeature.P2PTunnel, AEFeature.P2PTunnelEU ), EnumSet.of( IntegrationType.IC2 ), | |||
// PartP2PIC2Power.class, GuiText.EUTunnel ), | |||
P2PTunnelEU( 465, "p2p_tunnel_ic2", EnumSet.of( AEFeature.P2PTunnel, AEFeature.P2PTunnelEU ), EnumSet.of( IntegrationType.IC2 ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | ||
|
||
@Override | ||
public double injectEnergy( EnumFacing directionFrom, double amount, double voltage ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | ||
} | ||
} | ||
catch( GridAccessException e ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ | ||
outs = this.getOutputs(); | ||
} | ||
catch( GridAccessException e ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | ||
|
||
// Buffer the energy + voltage for two IC2 ENET packets | ||
private double bufferedEnergy1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
// Buffer the energy + voltage for two IC2 ENET packets | ||
private double bufferedEnergy1; | ||
private double bufferedVoltage1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Buffer the energy + voltage for two IC2 ENET packets | ||
private double bufferedEnergy1; | ||
private double bufferedVoltage1; | ||
private double bufferedEnergy2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private double bufferedEnergy1; | ||
private double bufferedVoltage1; | ||
private double bufferedEnergy2; | ||
private double bufferedVoltage2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private double bufferedEnergy2; | ||
private double bufferedVoltage2; | ||
|
||
public PartP2PIC2Power( ItemStack is ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SonarQube analysis reported 16 issues Watch the comments in this conversation to review them. 5 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
Refactored layers and implemented IC2 Tunnel on top of it