Removed ASMTweaker and replaced it with AT. #2636

Merged
merged 1 commit into from Nov 26, 2016

Projects

None yet

2 participants

@yueh
Member
yueh commented Nov 18, 2016

First Iteration, do not merge

Added appeng_at.cfg and updated build.gradle to correctly include the AT when building.
Deleted the now useless ASMTweaker.
Moved the coremod from package transformer to coremod as a better matching name.
Updated the old 1.7.10 code using reflection to drop it where forge or vanilla now exposes that functionality directly.

@yueh yueh Removed ASMTweaker and replaced it with AT.
Added appeng_at.cfg and updated build.gradle to correctly include the AT
when building.
Deleted the now useless ASMTweaker.
Moved the coremod from package transformer to coremod as a better matching
name.
Updated the old 1.7.10 code using reflection to drop it where forge or
vanilla now exposes that functionality directly.
ad57755
@orod-org

SonarQube analysis reported 41 issues

  • CRITICAL 11 critical
  • MAJOR 15 major
  • MINOR 11 minor
  • INFO 4 info

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL AppEngCore.java#L60: Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. rule
  2. CRITICAL AppEngCore.java#L84: Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. rule
  3. CRITICAL ASMIntegration.java#L104: The Cyclomatic Complexity of this method "removeOptionals" is 14 which is greater than 10 authorized. rule
  4. CRITICAL ASMIntegration.java#L114: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  5. CRITICAL ASMIntegration.java#L121: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  6. CRITICAL ASMIntegration.java#L141: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  7. CRITICAL ASMIntegration.java#L165: The Cyclomatic Complexity of this method "stripInterface" is 12 which is greater than 10 authorized. rule
  8. CRITICAL ASMIntegration.java#L184: Define a constant instead of duplicating this literal "iname" 3 times. rule
  9. CRITICAL ASMIntegration.java#L198: Define a constant instead of duplicating this literal " because " 4 times. rule
  10. CRITICAL ASMIntegration.java#L198: Define a constant instead of duplicating this literal " from " 4 times. rule
@@ -155,7 +155,7 @@
*/
private static final Random RANDOM_GENERATOR = new Random();
private static final WeakHashMap<World, EntityPlayer> FAKE_PLAYERS = new WeakHashMap<World, EntityPlayer>();
- private static Method getEntry;
+ // private static Method getEntry;
@orod-org
orod-org Nov 18, 2016

MAJOR This block of commented-out lines of code should be removed. rule

@yueh yueh merged commit 887339f into master Nov 26, 2016

3 of 4 checks passed

sonarqube SonarQube reported 41 issues, with 11 critical
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details
@yueh yueh deleted the feature-coremod-refactoring branch Nov 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment