Replaced Watcher using Collection with a more fitting interface #2693

Merged
merged 3 commits into from Dec 14, 2016

Projects

None yet

2 participants

@yueh
Member
yueh commented Dec 8, 2016 edited

Fixes #229.

yueh added some commits Dec 8, 2016
@yueh yueh Replaced Watcher using Collection with a more fitting interface 59ea319
@yueh yueh Box double and fix code style
3369655
@yueh yueh Changed useless contains Double
41e8f17
@orod-org

SonarQube analysis reported 1 issue

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR CraftingGridCache.java#L485: appeng.me.cache.CraftingGridCache.getCraftingFor(IAEItemStack, ICraftingPatternDetails, int, World) makes inefficient use of keySet iterator instead of entrySet iterator rule
@yueh yueh merged commit fb79fd2 into master Dec 14, 2016

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details
sonarqube SonarQube reported 1 issue, no criticals or blockers
@yueh yueh deleted the feature-watcher-refactoring branch Dec 14, 2016
@phit phit added a commit to Stonebound/Applied-Energistics-2 that referenced this pull request Dec 19, 2016
@yueh @phit yueh + phit Replaced Watcher using Collection with a more fitting interface (#2693)
Replaced the watchers for energy, storage and crafting with a more fitting interface compared to a common collection.

Fixes #229
41d44f7
@phit phit added a commit to Stonebound/Applied-Energistics-2 that referenced this pull request Dec 19, 2016
@yueh @phit yueh + phit Replaced Watcher using Collection with a more fitting interface (#2693)
Replaced the watchers for energy, storage and crafting with a more fitting interface compared to a common collection.

Fixes #229
e3fecbc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment