Feature theoneprobe integration #2696

Merged
merged 4 commits into from Dec 14, 2016

Projects

None yet

2 participants

@yueh
Member
yueh commented Dec 11, 2016

Displayed information is equal to current the WAILA integration.

Added a preInit stage to IIntegrationModule.
Added a factory method to IntegrationType to avoid touching IntegrationNode for every new integration.

Fixes #2650

+ {
+ return Iterators.size( tunnel.getOutputs().iterator() );
+ }
+ catch( GridAccessException e )
@orod-org
orod-org Dec 11, 2016

MAJOR Either log or rethrow this exception. rule

@@ -27,6 +27,10 @@ default boolean isEnabled()
return true;
}
+ default void preInit() throws Throwable
@orod-org
orod-org Dec 11, 2016

MAJOR Define and throw a dedicated exception instead of using a generic one. rule

+
+ }
+
+ private String getToolTip( final boolean isActive, final boolean isPowered )
@orod-org
orod-org Dec 11, 2016

MAJOR Remove this unused private "getToolTip" method. rule

yueh added some commits Dec 11, 2016
@yueh yueh Added TheOneProbe integration
Displayed information is equal to current the WAILA integration.

Added a preInit stage to IIntegrationModule.
Added a factory method to IntegrationType to avoid touching
IntegrationNode for every new integration.

Fixes #2650
8c840e3
@yueh yueh Fixed Crafting Monitor layout 3d4205a
@yueh yueh Prevent displaying channel info on unpowered networks.
Some styling fixes.
9a199f8
@yueh yueh Some cleanup
390bc80
+ * Similar to {@link IProbeInfoProvider}, but already providing the {@link AEBaseTile} being looked at.
+ *
+ */
+public interface ITileProbInfoProvider
@orod-org
orod-org Dec 14, 2016

CRITICAL Annotate the "ITileProbInfoProvider" interface with the @FunctionalInterface annotation rule

+ * Similar to {@link IProbeInfoProvider}, but already providing the {@link IPart} being looked at.
+ *
+ */
+public interface IPartProbInfoProvider
@orod-org
orod-org Dec 14, 2016

CRITICAL Annotate the "IPartProbInfoProvider" interface with the @FunctionalInterface annotation rule

@orod-org

SonarQube analysis reported 9 issues

  • CRITICAL 3 critical
  • MAJOR 3 major
  • MINOR 3 minor

Watch the comments in this conversation to review them.

3 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MINOR IntegrationNode.java#L28: Remove this unused import 'appeng.integration.modules.ic2.IC2Module'. rule
  2. MINOR IntegrationNode.java#L29: Remove this unused import 'appeng.integration.modules.jei.JEIModule'. rule
  3. MINOR IntegrationNode.java#L30: Remove this unused import 'appeng.integration.modules.waila.WailaModule'. rule
@yueh yueh merged commit 8bed7f2 into master Dec 14, 2016

3 of 4 checks passed

sonarqube SonarQube reported 9 issues, with 3 critical
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details
@yueh yueh deleted the feature-theoneprobe-integration branch Dec 14, 2016
@phit phit added a commit to Stonebound/Applied-Energistics-2 that referenced this pull request Dec 19, 2016
@yueh @phit yueh + phit TheOneProbe integration (#2696)
Displayed information is equal to current the WAILA integration.

Added a preInit stage to IIntegrationModule.
Added a factory method to IntegrationType to avoid touching
IntegrationNode for every new integration.

Fixes #2650
0bef5c5
@phit phit added a commit to Stonebound/Applied-Energistics-2 that referenced this pull request Dec 19, 2016
@yueh @phit yueh + phit TheOneProbe integration (#2696)
Displayed information is equal to current the WAILA integration.

Added a preInit stage to IIntegrationModule.
Added a factory method to IntegrationType to avoid touching
IntegrationNode for every new integration.

Fixes #2650
f916228
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment