Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2750: Added missing RF Integration Modules. #2770

Merged
merged 4 commits into from Jan 31, 2017
Merged

Fixes #2750: Added missing RF Integration Modules. #2770

merged 4 commits into from Jan 31, 2017

Conversation

@yueh
Copy link
Member

@yueh yueh commented Jan 27, 2017

Readded the integration modules for both RF integrations.
These are necessary to correctly enable RF support as well as act as fallback to disable it automatically on missing interfaces.
Removed superfluous integration types.


public class RFItemModule implements IIntegrationModule
{
public RFItemModule()

This comment has been minimized.

@orod-org

orod-org Jan 27, 2017

MAJOR Hide this public constructor. rule


public class RFTileModule implements IIntegrationModule
{
public RFTileModule()

This comment has been minimized.

@orod-org

orod-org Jan 27, 2017

MAJOR Hide this public constructor. rule

Readded the integration modules for both RF integrations.
These are necessary to correctly enable RF support as well as act as
fallback to disable it automatically on missing interfaces.
@yueh yueh force-pushed the fix-2750 branch from 295bcfc to e538540 Jan 27, 2017
yueh added 3 commits Jan 27, 2017
Added a unittest to ensure an integration types instaniates an integration
module without throwing any exception.
Improved the logging should this ever happen at runtime again.
@orod-org
Copy link

@orod-org orod-org commented Jan 27, 2017

SonarQube analysis reported 2 issues

  • MAJOR 2 major

Watch the comments in this conversation to review them.

@yueh yueh merged commit 12b0527 into master Jan 31, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details
sonarqube SonarQube reported 2 issues, no criticals or blockers
@yueh yueh deleted the fix-2750 branch Jan 31, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants