New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Remove storage/import/export bus IItemHandler caching #2987

Merged
merged 2 commits into from Jul 31, 2017

Conversation

Projects
None yet
4 participants
@fscan
Member

fscan commented Jul 29, 2017

For StorageBus - like the old version - a hash made of TileEntity, IItemHandler and number of slots is built.

Fixes #2982

@orod-org

This comment has been minimized.

Show comment
Hide comment
@orod-org

orod-org Jul 29, 2017

SonarQube analysis reported 4 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR Platform.java#L604: Remove this useless assignment to local variable "itemStack". rule
  2. MAJOR Platform.java#L649: Remove this useless assignment to local variable "itemStack". rule
  3. MAJOR Platform.java#L1663: This block of commented-out lines of code should be removed. rule
  4. MINOR Platform.java#L461: Remove this use of "getDrops"; it is deprecated. rule

orod-org commented Jul 29, 2017

SonarQube analysis reported 4 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR Platform.java#L604: Remove this useless assignment to local variable "itemStack". rule
  2. MAJOR Platform.java#L649: Remove this useless assignment to local variable "itemStack". rule
  3. MAJOR Platform.java#L1663: This block of commented-out lines of code should be removed. rule
  4. MINOR Platform.java#L461: Remove this use of "getDrops"; it is deprecated. rule
@fscan

This comment has been minimized.

Show comment
Hide comment
@fscan

fscan Jul 30, 2017

Member

fixes #2982

Member

fscan commented Jul 30, 2017

fixes #2982

@yueh yueh added this to the rv5.alpha - 1.12 milestone Jul 31, 2017

@yueh yueh merged commit b13a338 into AppliedEnergistics:rv5-1.12 Jul 31, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins Success
Details
sonarqube SonarQube reported 4 issues, no criticals or blockers
@xsun2001

This comment has been minimized.

Show comment
Hide comment
@xsun2001

xsun2001 Jun 16, 2018

Hey guys.
I am merging the patches of higher version to 1.7.10 recently. But I cannot cherry-pick this PR easily because of the lack of IItemHandler and Capability system. I would like to know if the merger of this branch can help reduce some potential bugs in 1.7.10. I also want to know how to merge this branch without IItemHandler. Can I call net.minecraft.inventory.IInventory#getStackInSlot for every available index to get everything in it?

xsun2001 commented Jun 16, 2018

Hey guys.
I am merging the patches of higher version to 1.7.10 recently. But I cannot cherry-pick this PR easily because of the lack of IItemHandler and Capability system. I would like to know if the merger of this branch can help reduce some potential bugs in 1.7.10. I also want to know how to merge this branch without IItemHandler. Can I call net.minecraft.inventory.IInventory#getStackInSlot for every available index to get everything in it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment