New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Inscriber and Molecular Assembler #2995

Merged
merged 4 commits into from Jul 31, 2017

Conversation

Projects
None yet
5 participants
@fscan
Member

fscan commented Jul 31, 2017

Fix some bugs introduced in the rewrite.

@fscan fscan changed the title from Fix inscriber to Fix Inscriber and Molecular Assembler Jul 31, 2017

@orod-org

This comment has been minimized.

Show comment
Hide comment
@orod-org

orod-org Jul 31, 2017

SonarQube analysis reported 8 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MINOR TileMolecularAssembler.java#L202: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  2. MINOR TileMolecularAssembler.java#L210: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  3. MINOR TileMolecularAssembler.java#L216: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  4. MINOR TileMolecularAssembler.java#L237: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  5. MINOR TileInscriber.java#L135: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  6. MINOR TileInscriber.java#L145: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  7. MINOR TileInscriber.java#L155: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  8. MINOR TileInscriber.java#L184: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule

orod-org commented Jul 31, 2017

SonarQube analysis reported 8 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MINOR TileMolecularAssembler.java#L202: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  2. MINOR TileMolecularAssembler.java#L210: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  3. MINOR TileMolecularAssembler.java#L216: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  4. MINOR TileMolecularAssembler.java#L237: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  5. MINOR TileInscriber.java#L135: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  6. MINOR TileInscriber.java#L145: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  7. MINOR TileInscriber.java#L155: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  8. MINOR TileInscriber.java#L184: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule

@yueh yueh merged commit 0f9ac5f into AppliedEnergistics:rv5-1.12 Jul 31, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins Success
Details
sonarqube SonarQube reported 8 issues, no criticals or blockers

@yueh yueh added this to the rv5.alpha - 1.12 milestone Jul 31, 2017

@yueh yueh referenced this pull request Aug 3, 2017

Closed

[1.12] Inscriber Issue #2998

@ridvanonal

This comment has been minimized.

Show comment
Hide comment
@ridvanonal

ridvanonal Aug 3, 2017

When we use the inscriber correctly? Next aplha?

ridvanonal commented Aug 3, 2017

When we use the inscriber correctly? Next aplha?

@chooven

This comment has been minimized.

Show comment
Hide comment
@chooven

chooven Aug 7, 2017

Hello, we are having a problem in All the mods 3 with getting the same processor out of the inscribers no matter what circuit is used. Will this fix that problem or should I create a new issue? Thank you

chooven commented Aug 7, 2017

Hello, we are having a problem in All the mods 3 with getting the same processor out of the inscribers no matter what circuit is used. Will this fix that problem or should I create a new issue? Thank you

@fscan

This comment has been minimized.

Show comment
Hide comment
@fscan

fscan Aug 7, 2017

Member

Please try with latest alpha (rv5-alpha-2) and open an issue if it is still happening

Member

fscan commented Aug 7, 2017

Please try with latest alpha (rv5-alpha-2) and open an issue if it is still happening

@chooven

This comment has been minimized.

Show comment
Hide comment
@chooven

chooven Aug 8, 2017

fscan, tried it with ATM3 and alpha 2 works like a champ, i was able to make all three processors.

Thanks

chooven commented Aug 8, 2017

fscan, tried it with ATM3 and alpha 2 works like a champ, i was able to make all three processors.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment