New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead space at top of text fields #300

Closed
wants to merge 4 commits into
base: rv2
from

Conversation

Projects
None yet
2 participants
@Cisien
Contributor

Cisien commented Oct 12, 2014

No description provided.

Cisien added some commits Oct 12, 2014

Tweaked the layout of some text fields
Adjusted the area where a click sets focus
Tweaked the layout of some text fields
Adjusted the area where a click sets focus
Merge remote-tracking branch 'origin/rv2' into rv2-textboxes
Conflicts:
	src/main/java/appeng/client/gui/widgets/MEGuiTextField.java
super.mouseClicked(x, y, btn);
boolean setFocus = isMouseIn(x, y);
this.setFocused(setFocus);

This comment has been minimized.

@thatsIch

thatsIch Oct 12, 2014

Member

The click area for Text Fields fits in height but not on X-axis. Its missing some pixles to the left and right. Intentional?

@thatsIch

thatsIch Oct 12, 2014

Member

The click area for Text Fields fits in height but not on X-axis. Its missing some pixles to the left and right. Intentional?

@Cisien

This comment has been minimized.

Show comment
Hide comment
@Cisien

Cisien Oct 12, 2014

Contributor

latest commit should cover the full text box

Contributor

Cisien commented Oct 12, 2014

latest commit should cover the full text box

@Cisien Cisien added this to the rv2 milestone Oct 12, 2014

@thatsIch

This comment has been minimized.

Show comment
Hide comment
@thatsIch

thatsIch Oct 13, 2014

Member

now the clickbox is too wide. The textbox already activates quite far away.

https://imgur.com/a/VL0I6

€: gg, did not show mouse xD its basically 3-4 pixles off to the right of the textbox

Member

thatsIch commented Oct 13, 2014

now the clickbox is too wide. The textbox already activates quite far away.

https://imgur.com/a/VL0I6

€: gg, did not show mouse xD its basically 3-4 pixles off to the right of the textbox

@Cisien

This comment has been minimized.

Show comment
Hide comment
@Cisien

Cisien Oct 15, 2014

Contributor

Here are a couple of screen shots that illustrate the issue:
http://paste.cisien.com/f/901a0c00.png
http://paste.cisien.com/f/89a769d8.png

Note the difference in size between the size of the actual text field (the black box is the result of searchField.setEnableBackgroundDrawing( true );)

because the texture doesn't line up the same between the normal terminal/crafting terminal in comparison to the Interface terminal, the IsMouseIn method can't return the click area perfectly for all terminals :/

The other problem is that the text field width snaps to a character width, so there isn't the fine-tuned control needed to make it fill the space properly.

My vote is to leave this as it is in this PR, even though the interface terminal overflows the text box.

Longer term, a pass should be made on all the GUI assets to match the graphical representation of a text input box with the actual text field control.

Contributor

Cisien commented Oct 15, 2014

Here are a couple of screen shots that illustrate the issue:
http://paste.cisien.com/f/901a0c00.png
http://paste.cisien.com/f/89a769d8.png

Note the difference in size between the size of the actual text field (the black box is the result of searchField.setEnableBackgroundDrawing( true );)

because the texture doesn't line up the same between the normal terminal/crafting terminal in comparison to the Interface terminal, the IsMouseIn method can't return the click area perfectly for all terminals :/

The other problem is that the text field width snaps to a character width, so there isn't the fine-tuned control needed to make it fill the space properly.

My vote is to leave this as it is in this PR, even though the interface terminal overflows the text box.

Longer term, a pass should be made on all the GUI assets to match the graphical representation of a text input box with the actual text field control.

@thatsIch

This comment has been minimized.

Show comment
Hide comment
@thatsIch

thatsIch Oct 16, 2014

Member

using setEnableBackgroundDrawing does change the render also. I am gonna try something.

Member

thatsIch commented Oct 16, 2014

using setEnableBackgroundDrawing does change the render also. I am gonna try something.

@thatsIch

This comment has been minimized.

Show comment
Hide comment
@thatsIch

thatsIch Oct 16, 2014

Member

Closes this in favor of #311

Member

thatsIch commented Oct 16, 2014

Closes this in favor of #311

@thatsIch thatsIch closed this Oct 16, 2014

@thatsIch thatsIch removed this from the rv2 milestone Oct 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment