Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead space at top of text fields #300

Closed
wants to merge 4 commits into from

Conversation

@Cisien
Copy link
Contributor

@Cisien Cisien commented Oct 12, 2014

No description provided.

Cisien added 3 commits Oct 12, 2014
Adjusted the area where a click sets focus
Adjusted the area where a click sets focus
Conflicts:
	src/main/java/appeng/client/gui/widgets/MEGuiTextField.java
super.mouseClicked(x, y, btn);

boolean setFocus = isMouseIn(x, y);
this.setFocused(setFocus);

This comment has been minimized.

@thatsIch

thatsIch Oct 12, 2014
Member

The click area for Text Fields fits in height but not on X-axis. Its missing some pixles to the left and right. Intentional?

@Cisien
Copy link
Contributor Author

@Cisien Cisien commented Oct 12, 2014

latest commit should cover the full text box

@Cisien Cisien added the enhancement label Oct 12, 2014
@Cisien Cisien added this to the rv2 milestone Oct 12, 2014
@thatsIch
Copy link
Member

@thatsIch thatsIch commented Oct 13, 2014

now the clickbox is too wide. The textbox already activates quite far away.

https://imgur.com/a/VL0I6

€: gg, did not show mouse xD its basically 3-4 pixles off to the right of the textbox

@Cisien
Copy link
Contributor Author

@Cisien Cisien commented Oct 15, 2014

Here are a couple of screen shots that illustrate the issue:
http://paste.cisien.com/f/901a0c00.png
http://paste.cisien.com/f/89a769d8.png

Note the difference in size between the size of the actual text field (the black box is the result of searchField.setEnableBackgroundDrawing( true );)

because the texture doesn't line up the same between the normal terminal/crafting terminal in comparison to the Interface terminal, the IsMouseIn method can't return the click area perfectly for all terminals :/

The other problem is that the text field width snaps to a character width, so there isn't the fine-tuned control needed to make it fill the space properly.

My vote is to leave this as it is in this PR, even though the interface terminal overflows the text box.

Longer term, a pass should be made on all the GUI assets to match the graphical representation of a text input box with the actual text field control.

@thatsIch
Copy link
Member

@thatsIch thatsIch commented Oct 16, 2014

using setEnableBackgroundDrawing does change the render also. I am gonna try something.

@thatsIch
Copy link
Member

@thatsIch thatsIch commented Oct 16, 2014

Closes this in favor of #311

@thatsIch thatsIch closed this Oct 16, 2014
@thatsIch thatsIch removed this from the rv2 milestone Oct 16, 2014
@thatsIch thatsIch removed the enhancement label Oct 16, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.