New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ME IO Port GUI #3019

Merged
merged 1 commit into from Aug 9, 2017

Conversation

Projects
None yet
3 participants
@fscan
Member

fscan commented Aug 8, 2017

Same problem as the others, filtered itemhandlers should not be used internally. UI still needs to be able to extract from input slots.

@orod-org

This comment has been minimized.

Show comment
Hide comment
@orod-org

orod-org Aug 8, 2017

SonarQube analysis reported 3 issues

  • MAJOR 1 major
  • MINOR 2 minor

Watch the comments in this conversation to review them.

2 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MINOR TileIOPort.java#L115: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  2. MINOR TileIOPort.java#L125: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule

orod-org commented Aug 8, 2017

SonarQube analysis reported 3 issues

  • MAJOR 1 major
  • MINOR 2 minor

Watch the comments in this conversation to review them.

2 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MINOR TileIOPort.java#L115: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  2. MINOR TileIOPort.java#L125: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
@@ -107,9 +109,6 @@ public TileIOPort()
final Block ioPortBlock = AEApi.instance().definitions().blocks().iOPort().maybeBlock().get();

This comment has been minimized.

@orod-org

orod-org Aug 8, 2017

MAJOR Call "Optional#isPresent()" before accessing the value. rule

@orod-org

orod-org Aug 8, 2017

MAJOR Call "Optional#isPresent()" before accessing the value. rule

This comment has been minimized.

@yueh

yueh Aug 9, 2017

Member

Just as a quick notice. While technically correct, the tile itself is only present when the block is present itself. So it already has an implicit isPresent() check. But sometimes I feel like we should add a quick comment as someone might not immediately realise the transitive relation. Not now, just something to think about.

@yueh

yueh Aug 9, 2017

Member

Just as a quick notice. While technically correct, the tile itself is only present when the block is present itself. So it already has an implicit isPresent() check. But sometimes I feel like we should add a quick comment as someone might not immediately realise the transitive relation. Not now, just something to think about.

@yueh yueh added the review-accepted label Aug 9, 2017

@yueh yueh added this to the rv5.alpha - 1.12 milestone Aug 9, 2017

@yueh yueh merged commit 3b58f5e into AppliedEnergistics:rv5-1.12 Aug 9, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins Success
Details
sonarqube SonarQube reported 3 issues, no criticals or blockers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment