Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fill existing stacks first when adding to player inventory. #3025
Buggy implementations are sadly quite common. But there is also the chance that we do not know the source of an itemstack, so they might expect that we do not modify the itemstack similar the an itemhandler, which must not changed to passed one at all.
Also copying an itemstack is not that bad in controlled cases. It only gets out of hand when moving a couple of 10k item/tick around. And it usually needs very good optimitized inventories to even allow it.
Therefore I would err on the side of caution and keep it.