New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inscriber improvements and fixes #3028

Merged
merged 1 commit into from Aug 12, 2017

Conversation

Projects
None yet
3 participants
@fscan
Member

fscan commented Aug 12, 2017

*) allow stacking in output slot
*) fix renaming items in GUI

@orod-org

This comment has been minimized.

Show comment
Hide comment
@orod-org

orod-org Aug 12, 2017

SonarQube analysis reported 5 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR ContainerInscriber.java#L167: Remove this useless assignment to local variable "otherSlot". rule
  2. MINOR TileInscriber.java#L137: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  3. MINOR TileInscriber.java#L147: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  4. MINOR TileInscriber.java#L157: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  5. MINOR TileInscriber.java#L186: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule

orod-org commented Aug 12, 2017

SonarQube analysis reported 5 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR ContainerInscriber.java#L167: Remove this useless assignment to local variable "otherSlot". rule
  2. MINOR TileInscriber.java#L137: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  3. MINOR TileInscriber.java#L147: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  4. MINOR TileInscriber.java#L157: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  5. MINOR TileInscriber.java#L186: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule

@yueh yueh added this to the rv5.alpha - 1.12 milestone Aug 12, 2017

@yueh yueh merged commit 3e2bc0e into AppliedEnergistics:rv5-1.12 Aug 12, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins Success
Details
sonarqube SonarQube reported 5 issues, no criticals or blockers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment